Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a Window warning on X11 when XInput2 is not available #321

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Fix a Window warning on X11 when XInput2 is not available #321

merged 1 commit into from
Nov 11, 2024

Conversation

v-dobrev
Copy link
Member

@v-dobrev v-dobrev commented Nov 7, 2024

The warning that this PR fixes is:

lib/sdl_x11.cpp: In member function ‘virtual void SdlX11Platform::RegisterWindow(SDL_Window*)’:
lib/sdl_x11.cpp:48:11: warning: unused variable ‘wnd’ [-Wunused-variable]
   48 |    Window wnd = sysinfo.info.x11.window;
      |           ^~~

tzanio
tzanio approved these changes Nov 10, 2024
View reviewed changes
Copy link
Member

@tzanio tzanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @v-dobrev

@tzanio
Copy link
Member

tzanio commented Nov 10, 2024

@najlkin and @justinlaughlin -- can I get another approval so we can merge this fix (it affects autotest)

najlkin
najlkin approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@najlkin najlkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@najlkin najlkin merged commit 419914c into master Nov 11, 2024
10 checks passed
@najlkin najlkin deleted the x11-window-warning-fix branch November 11, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@najlkin najlkin najlkin approved these changes

@tzanio tzanio tzanio approved these changes

@justinlaughlin justinlaughlin Awaiting requested review from justinlaughlin

Assignees
No one assigned
Labels
minor ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-dobrev @tzanio @najlkin