Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the command line output to behave better #2726

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

phlptp
Copy link
Member

@phlptp phlptp commented Jan 16, 2025

Summary

If merged this pull request will adjust the output flag for recorders/clone and add capture flag for clone

Proposed changes

@phlptp phlptp requested a review from trevorhardy January 16, 2025 20:26
@trevorhardy
Copy link
Contributor

helics_app clone --capture=Battery --output=battery_clone.json --loglevel=trace fails to produce "battery_clone.json" with the following "helics_cloner.log":

[2025-01-31 11:23:26.704] [console] [trace] Clone_core_fsZRzj (1879048192)[connected]::|| priority_cmd:fed_ack:Clone--131072 from 1
[2025-01-31 11:23:26.705] [console] [trace] Clone (131072)[created]::processing command fed_ack:Clone--131072
clone subcommand
[2025-01-31 11:23:26.705] [console] [trace] Clone_core_fsZRzj (1879048192)[connected]::|| cmd:unknown 937 from -235262
[2025-01-31 11:23:26.706] [console] [trace] Clone_core_fsZRzj (1879048192)[connected]::|| cmd:unknown 942 from 1
[2025-01-31 11:23:26.706] [console] [trace] Clone_core_fsZRzj (1879048192)[connected]::|| cmd:init:From 131072 from 131072
[2025-01-31 11:23:27.158] [console] [trace] Clone_core_fsZRzj (1879048192)[initializing]::|| cmd:init_grant:From 1 from 1
[2025-01-31 11:23:27.158] [console] [trace] Clone (131072)[created]::processing command init_grant:From 1
[2025-01-31 11:23:27.158] [console] [debug] Clone (131072)[initializing]::Granting Initialization
[2025-01-31 11:23:27.158] [console] [debug] Clone (131072)[initializing]::Granted Time=-9223372036.854776
[2025-01-31 11:23:27.158] [console] [trace] Clone (131072)[initializing]::processing command exec_check:From 0
[2025-01-31 11:23:27.158] [console] [trace] Clone_core_fsZRzj (1879048192)[operating]::|| cmd:exec_request:From 131072 from 131072
[2025-01-31 11:23:27.158] [console] [trace] Clone (131072)[initializing]::processing command exec_request:From 131072
[2025-01-31 11:23:27.158] [console] [trace] Clone (131072)[initializing]::processing command exec_check:From 131072
[2025-01-31 11:23:27.158] [console] [debug] Clone (131072)[executing]::Granting Execution
[2025-01-31 11:23:27.158] [console] [debug] Clone (131072)[0]::Granted Time=0
[2025-01-31 11:23:27.158] [console] [trace] Clone (131072)[0]::{"granted_time":0,"requested_time":9223372036.854776, "exec":9223372036.854776, "allow":9223372036.854776, "value":9223372036.854776, "message":9223372036.854776, "minDe":9223372036.854776, "minminDe":9223372036.854776}
[2025-01-31 11:23:27.158] [console] [trace] Clone_core_fsZRzj (1879048192)[operating]::|| cmd:time_request:From (131072) Time(9223372036.854776, 0, 0) to (131072) from 131072
[2025-01-31 11:23:27.158] [console] [trace] Clone (131072)[0]::processing command time_request:From (131072) Time(9223372036.854776, 0, 0) to (131072)
[2025-01-31 11:23:27.158] [console] [debug] Clone (131072)[MAXTIME]::Granted Time=9223372036.854776
[2025-01-31 11:23:27.158] [console] [trace] Clone_core_fsZRzj (1879048192)[operating]::|| cmd:disconnect:From 131072 from 131072
[2025-01-31 11:23:27.159] [console] [trace] Clone (131072)[MAXTIME]::processing command disconnect:From 131072
[2025-01-31 11:23:27.159] [console] [trace] Clone_core_fsZRzj (1879048192)[operating]::|| cmd:disconnect:From 131072 from 131072
[2025-01-31 11:23:27.159] [console] [trace] Clone_core_fsZRzj (1879048192)[terminating]::|| cmd:disconnect core acknowledge:From 1 from 1
[2025-01-31 11:23:27.159] [console] [trace] Clone (131072)[MAXTIME]::processing command disconnect fed acknowledge:From 0
[2025-01-31 11:23:27.159] [console] [debug] Clone (131072)[MAXTIME]::Terminating
[2025-01-31 11:23:27.159] [console] [debug] Clone (131072)[MAXTIME]::Granted Time=9223372036.854776
[2025-01-31 11:23:27.199] [console] [trace] Clone_core_fsZRzj (1879048192)[terminating]::|| cmd:stop:From 0 from 0

@trevorhardy
Copy link
Contributor

helics_recorder recorder_config.txt --output= recorder_output.txt with "recorder_config.txt" of "Battery/EV1_current" running as a part of the fundamental default example produces a "recorder_output.txt" that contains recorded publications (excerpt below). This instantiation command of helics_recorder previously failed; see #2724.

#time 	tag	 type*	 value
60		Battery/EV1_current	double	"4.613610"
120		Battery/EV1_current	"4.604332"
180		Battery/EV1_current	"4.595110"
240		Battery/EV1_current	"4.585944"
300		Battery/EV1_current	"4.576831"
360		Battery/EV1_current	"4.567773"
420		Battery/EV1_current	"4.558769"
480		Battery/EV1_current	"4.549818"
540		Battery/EV1_current	"4.540919"
600		Battery/EV1_current	"4.532072"
660		Battery/EV1_current	"4.523277"
720		Battery/EV1_current	"4.514533"
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants