Fix install plugin workflow and error handling on desktop, update to electron 15

[cmdcolin]

The code in #2247 fails to automatically reload the page to the right session after the user has exited

This adds code in the Loader of jbrowse-desktop that allows specifying a "query parameter" to the electron session that let's it restore a particular config

This query parameters on desktop could also be used for automating desktop via the CLI

Also adds text searching to desktop...random add on but just found it in the process

[rbuels]

When adding text searching to desktop, nothing is going to be configured for it right now, so I’d expect things to act the same as before from the users perspective, right?

[cmdcolin]

When adding text searching to desktop, nothing is going to be configured for it right now, so I’d expect things to act the same as before from the users perspective, right?

The preloaded hg19 and hg38 sections include text searching preloads in this PR

[cmdcolin]

Marked as draft again because this PR sometimes is not reliably working, but unclear why

There is code like this that calls loadSession

  useEffect(() => {
    ;(async () => {
      if (config) {
        try {
          setLoading(true)
          console.log('before')
          const data = await ipcRenderer.invoke('loadSession', config)
          console.log('after')
          const pm = await createPluginManager(JSON.parse(data))
          setPluginManager(pm)
          setConfig('')
          setError(undefined)
        } catch (e) {
          console.log('err')
          console.error(e)
          setError(e)
        } finally {
          console.log('finally')
          setLoading(false)
        }
      }
    })()
  }, [config, setConfig])

Resulting console.log just says "before", no after, no finally, and no catch is executed

Looking at the ipc call I can add logging code to make it say

ipcMain.handle('loadSession', async (_event: unknown, sessionName: string) => {
  console.log('t1')
  const r = await readFile(getPath(sessionName), 'utf8')
  console.log('t2')
  return r
})

This correctly logs

t1
t2

To the console, so it should be returning the results...

So it's unclear why the ipcRenderer.invoke('loadSession',...) is not returning...

[codecov]

Codecov Report

Merging #2322 (897ce63) into main (5769c7e) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2322      +/-   ##
==========================================
- Coverage   61.92%   61.83%   -0.09%     
==========================================
  Files         511      511              
  Lines       23394    23427      +33     
  Branches     5428     5436       +8     
==========================================
  Hits        14487    14487              
- Misses       8639     8672      +33     
  Partials      268      268              

Impacted Files	Coverage Δ
products/jbrowse-desktop/src/Loader.tsx	0.00% <0.00%> (ø)
...e-desktop/src/StartScreen/data/preloadedConfigs.js	0.00% <ø> (ø)
products/jbrowse-desktop/src/StartScreen/index.tsx	0.00% <ø> (ø)
products/jbrowse-desktop/src/corePlugins.ts	100.00% <ø> (ø)
products/jbrowse-desktop/src/index.js	0.00% <ø> (ø)
products/jbrowse-desktop/src/jbrowseModel.js	2.73% <ø> (ø)
products/jbrowse-desktop/src/rootModel.ts	0.86% <0.00%> (-0.02%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5769c7e...897ce63. Read the comment docs.

[cmdcolin]

I am not precisely sure what caused the behavior described in #2322 (comment)

I did not really perform a root cause analysis but I stopped seeing it after a couple refactorings. if interested could dig deeper

Code also updates to electron 15 (just tested out while attempting refactorings, bug fixes n improvements always good... is not the reason for fix above though) and ports over a error handler (e.g. tells which snapshot failed) from jbrowse-web to jbrowse-desktop.