Export RefNameAutocomplete and ViewModel from LinearGenomeView for downstream usage #2382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
|
Looks like the failing lint/format checks are in a file unrelated to this PR, products/jbrowse-desktop/src/StartScreen/util.tsx |
|
@hextraza should be fixed on latest main now, can try rebasin off main branch |
rbuels
added
internal
and removed
needs label triage
|
Looks good to me. I checkout the branch and seems to be working appropriately, maybe fix lint as Colin mentions in the above comment. |
|
Okay, just rebased off of main, which should fix them. |
rbuels
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch exists to expose RefNameAutocomplete and associated types from the LinearGenomeView plugin, for usage as a search component by itself.