Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bulk delete of sessions on jbrowse-desktop #2387

Merged
merged 3 commits into from
Oct 7, 2021

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Oct 7, 2021

Using the cards, you still delete entries 1-by-1 but the table view offers a bulk delete

Screenshot from 2021-10-06 23-59-55

Also upgrades @material-ui/[email protected] to @mui/[email protected] (stable release) which is compatible with mui 4

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Oct 7, 2021
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Oct 7, 2021
@cmdcolin cmdcolin changed the title Add gmail style bulk delete of sessions Add gmail style bulk delete of sessions on jbrowse-desktop Oct 7, 2021
@cmdcolin cmdcolin removed the enhancement New feature or request label Oct 7, 2021
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #2387 (e82f9c2) into main (ad60c1d) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head e82f9c2 differs from pull request most recent head 879e44c. Consider uploading reports for the commit 879e44c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2387      +/-   ##
==========================================
- Coverage   61.05%   61.04%   -0.01%     
==========================================
  Files         533      533              
  Lines       24560    24554       -6     
  Branches     5767     5769       +2     
==========================================
- Hits        14994    14988       -6     
- Misses       9244     9250       +6     
+ Partials      322      316       -6     
Impacted Files Coverage Δ
...kages/core/BaseFeatureWidget/BaseFeatureDetail.tsx 75.36% <ø> (ø)
packages/core/ReExports/modules.ts 75.00% <ø> (ø)
...idBookmarkWidget/components/GridBookmarkWidget.tsx 90.24% <ø> (ø)
.../src/VariantFeatureWidget/VariantFeatureWidget.tsx 40.78% <ø> (ø)
...se-desktop/src/StartScreen/RecentSessionsPanel.tsx 0.00% <0.00%> (ø)
...ts/jbrowse-desktop/src/StartScreen/SessionCard.tsx 0.00% <0.00%> (ø)
...op/src/StartScreen/dialogs/DeleteSessionDialog.tsx 0.00% <0.00%> (ø)
products/jbrowse-desktop/src/StartScreen/index.tsx 0.00% <ø> (ø)
...nts/src/SNPCoverageRenderer/SNPCoverageRenderer.ts 80.24% <0.00%> (-7.41%) ⬇️
packages/core/util/index.ts 79.84% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad60c1d...879e44c. Read the comment docs.

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Oct 7, 2021
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Oct 7, 2021
@cmdcolin cmdcolin force-pushed the delete_button_startscreen branch 2 times, most recently from 4f5680b to e3d95f6 Compare October 7, 2021 21:06
@cmdcolin cmdcolin force-pushed the delete_button_startscreen branch from e3d95f6 to 879e44c Compare October 7, 2021 21:08
@cmdcolin cmdcolin merged commit cc4a26e into main Oct 7, 2021
@cmdcolin cmdcolin changed the title Add gmail style bulk delete of sessions on jbrowse-desktop Add bulk delete of sessions on jbrowse-desktop Oct 7, 2021
@cmdcolin cmdcolin deleted the delete_button_startscreen branch October 12, 2021 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant