-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting to color by query score per alignment for dotplot, support HTML in config slot descriptions #2483
Conversation
42a21a9
to
56f1d42
Compare
Codecov Report
@@ Coverage Diff @@
## main #2483 +/- ##
==========================================
- Coverage 60.93% 60.83% -0.10%
==========================================
Files 590 590
Lines 26729 26771 +42
Branches 6475 6483 +8
==========================================
+ Hits 16286 16287 +1
- Misses 10136 10177 +41
Partials 307 307
Continue to review full report at Codecov.
|
56f1d42
to
8df5aa6
Compare
788a1e6
to
31c1bc6
Compare
551dc59
to
2b8fdb5
Compare
Added an option for this to the colorBy option for dotplot renderer. Cites the dotPlotly tool since it is inspired by their result (example https://raw.githubusercontent.com/tpoorten/dotPlotly/master/example/Brapa_Bnapus.minimap2.plot.png) Example rendering with this setting turned on, showing the HTML |
2b8fdb5
to
f572e48
Compare
This should be ready to go One interesting thing is that I explicitly check if a config slot is a callback using config.isCallback. Is this a stable API to rely on? By checking if it is a callback, I can get the color with a single readConfObject instead of repeatedly calling readConfObject for each dot in a dotplot |
The other interesting thing as mentioned above is it now allows HTML in config slot descriptions, and uses our html sanitizer to render it |
f572e48
to
6631334
Compare
e92281a
to
6f1dcba
Compare
6f1dcba
to
4adbbe6
Compare
this should be good to go, I moved the calculation for the mean query score per alignment to only happen if we are actually performing the colorBy:meanQueryIdentity which means if it happens to be slow, it would only happen during this color by setting |
Inspired by https://github.com/tpoorten/dotPlotly/blob/master/example/README.md
Draft PR because maybe a more flexible color system is needed but this is a cool way where we can get a sense strong vs weak homology, useful for looking at ancient whole genome duplication or similar phenomena
may also be useful to have a legend or similar, and add to regular synteny view