Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trackhub registry failing to load in 2.x.y versions of jbrowse #3214

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

cmdcolin
Copy link
Collaborator

Fixes #3208

Missed the conversion to MUI5 due to being in js instead of TS! conversion to ts is a somewhat longer process, this is a quick fix

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Sep 23, 2022
@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Sep 23, 2022
@cmdcolin
Copy link
Collaborator Author

Note: this also removes the "sapiens" filter so all species are available!

@cmdcolin cmdcolin force-pushed the fix_trackhubregistry branch from 0483f92 to 6767768 Compare September 23, 2022 20:37
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Sep 23, 2022
@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #3214 (6767768) into main (414d69d) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3214      +/-   ##
==========================================
- Coverage   59.50%   59.48%   -0.03%     
==========================================
  Files         670      670              
  Lines       28748    28747       -1     
  Branches     6971     6971              
==========================================
- Hits        17107    17100       -7     
- Misses      11320    11326       +6     
  Partials      321      321              
Impacted Files Coverage Δ
...ackhub-registry/src/trackhub-registry/SelectBox.js 0.00% <0.00%> (ø)
...ry/src/trackhub-registry/TrackHubRegistrySelect.js 0.00% <0.00%> (ø)
...svg/src/SvgFeatureRenderer/components/Segments.tsx 85.71% <0.00%> (-7.15%) ⬇️
...src/SvgFeatureRenderer/components/FeatureLabel.tsx 80.55% <0.00%> (-5.56%) ⬇️
...gins/svg/src/SvgFeatureRenderer/components/util.ts 91.83% <0.00%> (-4.09%) ⬇️
...FeatureRenderer/components/ProcessedTranscript.tsx 87.32% <0.00%> (-1.41%) ⬇️
packages/core/util/layouts/GranularRectLayout.ts 86.86% <0.00%> (-0.43%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Sep 23, 2022
@cmdcolin cmdcolin merged commit 6a72a5c into main Sep 23, 2022
@cmdcolin cmdcolin deleted the fix_trackhubregistry branch September 23, 2022 23:57
@cmdcolin cmdcolin restored the fix_trackhubregistry branch December 15, 2022 20:13
@cmdcolin cmdcolin deleted the fix_trackhubregistry branch December 15, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add connections : The Track Hub Registry error
1 participant