add joint_type arg to relevant FilterRuptureId class methods #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chrisbc
commented
Feb 24, 2025
chrisbc
commented
- closing Feature: support join_type argument in new FilterRuptureId methods where iterables are supported #79
- add tolist() convenience method;
…s`; add tolist() conveniance method;
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## pre-release #80 +/- ##
===============================================
+ Coverage 99.29% 99.31% +0.02%
===============================================
Files 23 24 +1
Lines 1273 1318 +45
Branches 62 77 +15
===============================================
+ Hits 1264 1309 +45
Misses 8 8
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
chrisbc
changed the title
chrisdicaprio
approved these changes
Feb 25, 2025
chrisbc
added a commit
that referenced
this pull request
Feb 27, 2025
* new fault_system_solution_helper module * a simple rupture grouping algo; * drop_zero_rate differentiates between FSS and IS; * refactor subsection filter & tests * migrate to filter_rupture_ids.for_subsections(); * migrate to filter_rupture_ids.for_parent_fault_ids(); * fixed method names; added doc page for subsection_id_filter; * refactor filter tests; WIP on DeprecationWarnings; new filter_parent_fault_ids; detox * fixing many deprecation warnings; updated geopandas, pandas, numpy, pyvista libs; changes to read_csv_dtype configuration; detox * refactor filters int package; more test cover; implement new filters; migrate old functions and deprecate warn the originals; * unifying filter methods; improve docstrings & tests; * implement rate and mag filtering on rupture_id_filter; * migrate find rupture polygons into filter class; move drop_zero_rates into class init; * implement ChainableSetBase; migrate FilterRuptureIds to be chainable; * add set operation support for chaining (join_prior) and test coverage; * join arguments tidied up; strings and ENUMS are supported; * fix set operand method names; * fix set operations return type * implement set operands for supported set methods; improve docs * merge 3d geometry changes from @voj; add some testing; * new participation rate functions; detox * test 3d surfaces * migrate participation functions into classes proper; add FSS section_participation; * make subsection_id_filter chainable; * added participation methods to fault_system_solution * simplify FSS participation using rate_weighted_mean; refactor dataframe dtypes; participation performance testing; * standardise participation functions API and return column; * fix rate_column; add .all() methods to filter classes; * add TinyInversionSolution fixture; tune pytest fixture scoping for massive test speed up (~3 times faster); * doc and docstrings improvements; Better typing in filter package; * more on rupture_grouping * add module docstring to inversion_solution_file; * adding dataframe schema validations with panderas; * WIP, adding InversionSolutionFile::RuptureRateSchema; * Feature/52 refactor inversion solution (#53) * Chore/54 test coverage (#55) * Chore/59 doc fixes (#61) * make parent fault filter chainable (#66) * fix for #57 (return int type for polygons); * update pytz dep (#69) * Feature/49 named fault participation (#67) * Feature: named_fault_participation_rate #49 * Epic Feature: enhanced participation rate options #42 * refactor to remove *Protocol superclasses (#73) * refactor to remove *Protocol superclasses; migrate and improve docstrings; detox * Feature/71 scale rupture rates (#74) * fold in changes suggested by @chrisdicaprio on PR #73; * fix drop_zero_rates on FilterRuptureIds.for_magnitude(); * fix for_parent_fault_ids * fix test_ruptures_for_subsections * fix for_rupture_rate * fix for_polygon ; fix impacted tests; * Bump version: 0.13.0 → 1.0.0-alpha * add joint_type arg to relevant FilterRuptureId class methods (#80) * add joint_type arg to `for_parent_fault_names` * `for_parent_fault_ids`; add tolist() convenience method; * refactor for readability/efficiency; add full test coverage for new arg; * add `join_type` arg to `for_subsection_ids` (working but a little slow); detox; * rename arg for consistency * refactoring; new docstrings; named_faults support; detox; * remove commented line * changelog entry; * Bump version: 1.0.0-alpha → 1.0.0-beta * align version ids * Chore/82 make docs and api align (#83) * Bump version: 1.0.0-beta-0 → 1.0.0 --------- Co-authored-by: Chris DiCaprio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.