Implement JsonSchema on EnumSet type #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything else I need to do before this can be merged, or anything I can do to make it easier to review and merge? |
|
Thanks @mwcampbell, I've merged this in d059686 I didn't merge the second commit since the tests appear to work just fine on rust 1.37, I don't suppose you remember why you originally needed to exclude the tests from 1.37? |
|
I think I must have been over-reacting to an intermittent CI failure. @GREsau Is there anything blocking you from publishing a new release on crates.io now? |
|
Sorry for the delay, this is now on crates.io in 0.8.7! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enumset combines the efficiency of a bitmask with the ergonomics of a set of enum values. I'd like to use it with schemars, so I'm contributing support.