Skip to content

Commit

Permalink
Sk/remove historic data load (#4625)
Browse files Browse the repository at this point in the history
* Remove historic data load

* Restore

* Remove historic data load

* Restore

* Changes requested by Alex and Hassan

* Update
  • Loading branch information
gsa-suk authored Jan 21, 2025
1 parent 9cfe8d6 commit 42302c9
Show file tree
Hide file tree
Showing 11 changed files with 0 additions and 133 deletions.
8 changes: 0 additions & 8 deletions .github/workflows/deploy-application.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,14 +102,6 @@ jobs:
cf_vars_file: backend/manifests/vars/vars-${{ env.space }}.yml
command: bin/ops/deploy.sh

- name: Load historical data
uses: cloud-gov/cg-cli-tools@main
with:
cf_username: ${{ secrets.CF_USERNAME }}
cf_password: ${{ secrets.CF_PASSWORD }}
cf_org: gsa-tts-oros-fac
cf_space: ${{ env.space }}
command: cf run-task gsa-fac -k 6G -m 1G --name load_data --command "./load_data.sh"

# This has to happen after an application deployment because the manifest (currently) is responsible
# for binding the "logdrain service" to the "gsa-fac application". This also needs to be done
Expand Down
8 changes: 0 additions & 8 deletions .github/workflows/deploy-development.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,3 @@ jobs:
with:
url: "https://fac-dev.app.cloud.gov/"

generate-e2e-test-data:
needs:
- deploy-dev
name:
uses: ./.github/workflows/end-to-end-test-data-generator.yml
secrets: inherit
with:
environment: "dev"
56 changes: 0 additions & 56 deletions .github/workflows/end-to-end-test-data-generator.yml

This file was deleted.

4 changes: 0 additions & 4 deletions .github/workflows/testing-from-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,6 @@ jobs:
working-directory: ./backend
run: docker compose -f docker-compose.yml up -d

- name: Load historical data
working-directory: ./backend
run: docker compose run web ./load_data.sh

- name: Run Django test suite
working-directory: ./backend
run: docker compose -f docker-compose.yml run web bash -c 'coverage run --parallel-mode --concurrency=multiprocessing manage.py test --parallel && coverage combine && coverage report -m --fail-under=85 && coverage xml -o coverage.xml'
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/testing-from-ghcr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,6 @@ jobs:
working-directory: ./backend
run: docker compose -f docker-compose-web.yml up -d

- name: Load historical data
working-directory: ./backend
run: docker compose -f docker-compose-web.yml run web ./load_data.sh

- name: Run Django test suite
working-directory: ./backend
run: |
Expand Down
3 changes: 0 additions & 3 deletions backend/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,6 @@ docker-migrate:
python manage.py makemigrations &&\
python manage.py migrate'

docker-load-data:
docker compose up -d && docker compose run web ./load_data.sh

# Run Django tests with docker
docker-test:
docker compose build
Expand Down
9 changes: 0 additions & 9 deletions backend/dissemination/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -142,15 +142,6 @@ Check `backend/support/api/admin_api_v1_1_0/` for more examples.

# End-to-end workbook testing

### How to run the end-to-end test data generator:
```
docker compose run web python manage.py end_to_end_test_data_generator --email [email protected] \
--year 22 \
--dbkey 100010
```
- The email address currently must be a User in the system. As this has only been run locally so far, it would often be a test account in my local sandbox env.
- `year` and `dbkey` are optional. The script will use default values for these if they aren't provided.

### How to run the workbook generator:
```
docker compose run web python manage.py generate_workbook_files
Expand Down
11 changes: 0 additions & 11 deletions backend/docker-compose-dual-fac.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,6 @@ services:
timeout: 5s
retries: 10

#---------------------------------------------
# Historic data
#---------------------------------------------
historic-data:
image: ghcr.io/gsa-tts/fac-historic-public-csvs/load-historic-public-data:20230912
depends_on:
db:
condition: service_healthy
environment:
DATABASE_URL: postgres://postgres@db/postgres

#---------------------------------------------
# Django app
#---------------------------------------------
Expand Down
8 changes: 0 additions & 8 deletions backend/docker-compose-web.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,6 @@ services:
interval: 10s
timeout: 5s
retries: 10

historic-data:
image: ghcr.io/gsa-tts/fac-historic-public-csvs/load-historic-public-data:20230912
depends_on:
db:
condition: service_healthy
environment:
DATABASE_URL: postgres://postgres@db/postgres

web:
image: ghcr.io/gsa-tts/fac/web-container:latest
Expand Down
11 changes: 0 additions & 11 deletions backend/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,6 @@ services:
timeout: 5s
retries: 10

#---------------------------------------------
# Historic data
#---------------------------------------------
historic-data:
image: ghcr.io/gsa-tts/fac-historic-public-csvs/load-historic-public-data:20230912
depends_on:
db:
condition: service_healthy
environment:
DATABASE_URL: postgres://postgres@db/postgres

#---------------------------------------------
# Django app
#---------------------------------------------
Expand Down
11 changes: 0 additions & 11 deletions backend/load_data.sh

This file was deleted.

0 comments on commit 42302c9

Please sign in to comment.