Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E refactor: Clone tests all_should_pass and all_should_fail, plus workbooks #2727

Closed
Tracked by #2670
sambodeme opened this issue Nov 3, 2023 · 1 comment
Closed
Tracked by #2670
Assignees
Labels

Comments

@sambodeme
Copy link
Contributor

sambodeme commented Nov 3, 2023

This ticket is to replicate specific tests and their associated workbooks from the audit module to the census_historic_migration module, ensuring they function correctly in the new module.

Tasks to be completed:

  1. Clone the following test files from the audit module:

    • test_workbooks_should_pass.py
    • test_workbooks_should_fail.py
  2. Relocate the workbooks located in the audit module from:

    • audit/fixtures/workbooks/should_fail
    • audit/fixtures/workbooks/should_pass
      to a more centralized location that other modules can access. The chosen destination directories are:
    • data_fixtures/audit/workbooks/should_fail
    • data_fixtures/audit/workbooks/should_pass
  3. Modify the existing code within the audit module to ensure it references the workbooks in their new locations and continues to function properly.

  4. Adjust the newly cloned tests in the census_historic_migration module to correctly interact with the workbooks in their updated file paths.

@phildominguez-gsa
Copy link
Contributor

Determined newly generated workbooks can be placed in the existing test dir (FAC/backend/audit/fixtures/workbooks/should_*) and without having to move/modify the testing scripts

@github-project-automation github-project-automation bot moved this from Triage to Done in FAC Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants