Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search - Summary View Tests #2512

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Search - Summary View Tests #2512

merged 1 commit into from
Oct 16, 2023

Conversation

jperson1
Copy link
Contributor

Search - Summary View Tests

Base branch PR: #2419

Changes:

  1. New tests for the audit summary view under /dissemination/tests.py

How to test:

  1. Switch to this branch and run things normally.
  2. Run the relevant tests. I do this by:
    • Entering the docker shell via docker compose exec web /bin/bash
    • Running the dissemination-specific tests via python manage.py test dissemination.tests

PR checklist: submitters

  • Link to an issue if possible. If there’s no issue, describe what your branch does. Even if there is an issue, a brief description in the PR is still useful.
  • List any special steps reviewers have to follow to test the PR. For example, adding a local environment variable, creating a local test file, etc.
  • For extra credit, submit a screen recording like this one.
  • Make sure you’ve merged main into your branch shortly before creating the PR. (You should also be merging main into your branch regularly during development.)
  • Make sure that whatever feature you’re adding has tests that cover the feature. This includes test coverage to make sure that the previous workflow still works, if applicable.
  • Do manual testing locally. Our tests are not good enough yet to allow us to skip this step. If that’s not applicable for some reason, check this box.
  • Verify that no Git surgery was necessary, or, if it was necessary at any point, repeat the testing after it’s finished.
  • Once a PR is merged, keep an eye on it until it’s deployed to dev, and do enough testing on dev to verify that it deployed successfully, the feature works as expected, and the happy path for the broad feature area (such as submission) still works.

PR checklist: reviewers

  • Pull the branch to your local environment and run make docker-clean; make docker-first-run && docker compose up; then run docker compose exec web /bin/bash -c "python manage.py test"
  • Manually test out the changes locally, or check this box to verify that it wasn’t applicable in this case.
  • Check that the PR has appropriate tests. Look out for changes in HTML/JS/JSON Schema logic that may need to be captured in Python tests even though the logic isn’t in Python.
  • Verify that no Git surgery is necessary at any point (such as during a merge party), or, if it was, repeat the testing after it’s finished.

The larger the PR, the stricter we should be about these points.

@jperson1 jperson1 self-assigned this Oct 16, 2023
@jperson1 jperson1 changed the title Summary view tests Search- Summary View Tests Oct 16, 2023
@jperson1 jperson1 changed the title Search- Summary View Tests Search - Summary View Tests Oct 16, 2023
@timoballard timoballard merged commit c5f470c into mh/implement-mvp-search-form-2369 Oct 16, 2023
@timoballard timoballard deleted the jp/search-summary-tests branch October 16, 2023 19:12
github-merge-queue bot pushed a commit that referenced this pull request Oct 25, 2023
@heymatthenry @timoballard @jperson1
Search MVP (#2419)
d480d30 
* Add basic search form

* Add dummy results table

* move search to dissem app, impl basic form (#2431)

* Basic styles for search sidebar

* Style up results column

* [DRAFT] Search Summary (#2480)

* Search Summary

* Some title info, make tables take up the full width of the page

* Linting - py whitespace & imports, html closed tag

* Summary view tests (#2512)

* Flesh out Search view (#2494)

* fleshing out search view

* rm leftover list comprehension

* cog-over search fix, only search public

* more tests

* quick pass at displaying search results

* Add explainer text

* Remove filter chicklets (for now)

* Add pagination component

* Rm download all results button

* Add alt text

* Search - Pre-populate Form, Summary Link, Link Icons, Formatting (#2538)

* URLS - Add a backslash to the search url

* Search - Link to summary, icon size, formatting

* Summary - remove "back" button, formatting.

* Search - prepopulate form after making a search

* Remove usused import

* Don't run methods on empty data, kids

* Search - Move UEI and ALN above the name field

* Djlint reformatting

* Search - Audit Year (#2547)

* URLS - Add a backslash to the search url

* Search - Link to summary, icon size, formatting

* Summary - remove "back" button, formatting.

* Search - prepopulate form after making a search

* Remove usused import

* Don't run methods on empty data, kids

* Search - Move UEI and ALN above the name field

* Djlint reformatting

* Search - Add audit year

* search_general params default to none

* Tests - test_audit_year, search_general cleanups

* Revert "Merge branch 'mh/implement-mvp-search-form-2369' into jp/search-audit-year"

This reverts commit 7c99f95, reversing
changes made to 30b2743.

* Remove unused Y/N choices

* PDF downloads via Search (#2520)

* first pass at pdf downloads via search

* re-add AWS_S3_ENDPOINT_URL

* re-add download link

* linter

* fix cog_or_over field name mismatch

* fix search tests

* check if file exists in s3, else 404

* log warning if file not found in S3

---------

Co-authored-by: Matt Henry <[email protected]>
Co-authored-by: Tim Ballard <[email protected]>
Co-authored-by: Tim Ballard <[email protected]>
Co-authored-by: James Person <[email protected]>
Co-authored-by: James Person <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Oct 30, 2023
@jperson1 @timoballard
Summary Updates (#2605)
e75b450 
* Add basic search form

* Add dummy results table

* move search to dissem app, impl basic form (#2431)

* Basic styles for search sidebar

* Style up results column

* [DRAFT] Search Summary (#2480)

* Search Summary

* Some title info, make tables take up the full width of the page

* Linting - py whitespace & imports, html closed tag

* Summary view tests (#2512)

* Flesh out Search view (#2494)

* fleshing out search view

* rm leftover list comprehension

* cog-over search fix, only search public

* more tests

* quick pass at displaying search results

* Add explainer text

* Remove filter chicklets (for now)

* Add pagination component

* Rm download all results button

* Add alt text

* Search - Pre-populate Form, Summary Link, Link Icons, Formatting (#2538)

* URLS - Add a backslash to the search url

* Search - Link to summary, icon size, formatting

* Summary - remove "back" button, formatting.

* Search - prepopulate form after making a search

* Remove usused import

* Don't run methods on empty data, kids

* Search - Move UEI and ALN above the name field

* Djlint reformatting

* Search - Audit Year (#2547)

* URLS - Add a backslash to the search url

* Search - Link to summary, icon size, formatting

* Summary - remove "back" button, formatting.

* Search - prepopulate form after making a search

* Remove usused import

* Don't run methods on empty data, kids

* Search - Move UEI and ALN above the name field

* Djlint reformatting

* Search - Add audit year

* search_general params default to none

* Tests - test_audit_year, search_general cleanups

* Revert "Merge branch 'mh/implement-mvp-search-form-2369' into jp/search-audit-year"

This reverts commit 7c99f95, reversing
changes made to 30b2743.

* Remove unused Y/N choices

* PDF downloads via Search (#2520)

* first pass at pdf downloads via search

* re-add AWS_S3_ENDPOINT_URL

* re-add download link

* linter

* fix cog_or_over field name mismatch

* fix search tests

* check if file exists in s3, else 404

* log warning if file not found in S3

* Summary - restructure general, PDF download link

* getkey tag utilizes ".get" method.

* Remove useless return in test_audit_year

* Renaming - "Notes" -> "Notes to SEFA" in test

* Audit metadata, django comment over HTML comment

* Main.scss - override base-lighter, semibold to 600

* Summary - Updates. Table-based with workbook links

* Remove unused summary-general.html

* Grab additional UEI/EIN/Auditors

* django.contrib.humanize to installed apps.

* Mobile spacing

* Remove unneeded formatting. Lint!

* Remove passthroughs from the summary info

* Summary HTML - "disabled" cells if no data exists

* Lint - unused passthrough import

* Summary tests - remove passthrough

* Tests - actually remove passthrough. Oops.

* XLSX links

---------

Co-authored-by: Matt Henry <[email protected]>
Co-authored-by: Tim Ballard <[email protected]>
Co-authored-by: Tim Ballard <[email protected]>
JeanMarie-PM pushed a commit that referenced this pull request Oct 31, 2023
@phildominguez-gsa @danswick
@jadudm @sambodeme @tadhg-ohiggins @jperson1 @heymatthenry @timoballard @asteel-gsa
Catching up feature/historic-data with main (#2645)
65e9fad 
* Add management command and workflow for generating live test data from historical exports (#2569)

* First commit of E2E improvements

For running in production-like environments.

* add e2e generator workflow and profile changes

* lint

* double os

* more linting somehow

* don't do generation via profile

* Linting.

Runs defaults

* invoke via workflow instead of profile

* Apply suggestions from code review

* lint

---------

Co-authored-by: Matt Jadud <[email protected]>

* add workflow call to e2e data generator (#2571)

* This makes sure all of the named ranges exist (#2586)

* This makes sure all of the named ranges exist

Updates the ALN code slightly, and adds a new check that looks at the
workbook templates, and makes sure that all of the named ranges in the
template are in the file being submitted by the user

* Removed unused code and implemented logic to retrieve named range names

* Fix for string parsing issue

---------

Co-authored-by: Hassan D. M. Sambo <[email protected]>

* Add barebones feature allowing users to send submissions back to in progress from ready for certification (#2572)

* Add barebones feature allowing users to send submissions back to in progress from ready for certification.

* Coverage appeasement offering.

* More coverage appeasement.

* More coverage appeasement; this does fix an actual minor bug, though.

* Reduce test coverage pass threshold.

* Improve lock icon.

* Improve lock icon.

* Certification Unlock Copy & Styling Updates (#2595)

* Ready for certification - remove bolded & reformat

* Submissions homepage - icon on own line & format

* Certification unlock - format, copy, links.

* upload-cancel -> form-cancel

* "Straight quotation marks boo"

Co-authored-by: Tadhg O'Higgins <[email protected]>

---------

Co-authored-by: Tadhg O'Higgins <[email protected]>

* Search MVP (#2419)

* Add basic search form

* Add dummy results table

* move search to dissem app, impl basic form (#2431)

* Basic styles for search sidebar

* Style up results column

* [DRAFT] Search Summary (#2480)

* Search Summary

* Some title info, make tables take up the full width of the page

* Linting - py whitespace & imports, html closed tag

* Summary view tests (#2512)

* Flesh out Search view (#2494)

* fleshing out search view

* rm leftover list comprehension

* cog-over search fix, only search public

* more tests

* quick pass at displaying search results

* Add explainer text

* Remove filter chicklets (for now)

* Add pagination component

* Rm download all results button

* Add alt text

* Search - Pre-populate Form, Summary Link, Link Icons, Formatting (#2538)

* URLS - Add a backslash to the search url

* Search - Link to summary, icon size, formatting

* Summary - remove "back" button, formatting.

* Search - prepopulate form after making a search

* Remove usused import

* Don't run methods on empty data, kids

* Search - Move UEI and ALN above the name field

* Djlint reformatting

* Search - Audit Year (#2547)

* URLS - Add a backslash to the search url

* Search - Link to summary, icon size, formatting

* Summary - remove "back" button, formatting.

* Search - prepopulate form after making a search

* Remove usused import

* Don't run methods on empty data, kids

* Search - Move UEI and ALN above the name field

* Djlint reformatting

* Search - Add audit year

* search_general params default to none

* Tests - test_audit_year, search_general cleanups

* Revert "Merge branch 'mh/implement-mvp-search-form-2369' into jp/search-audit-year"

This reverts commit 7c99f95, reversing
changes made to 30b2743.

* Remove unused Y/N choices

* PDF downloads via Search (#2520)

* first pass at pdf downloads via search

* re-add AWS_S3_ENDPOINT_URL

* re-add download link

* linter

* fix cog_or_over field name mismatch

* fix search tests

* check if file exists in s3, else 404

* log warning if file not found in S3

---------

Co-authored-by: Matt Henry <[email protected]>
Co-authored-by: Tim Ballard <[email protected]>
Co-authored-by: Tim Ballard <[email protected]>
Co-authored-by: James Person <[email protected]>
Co-authored-by: James Person <[email protected]>

* fix cg internal endpoint setting (#2613)

* Add mgiration file that should have been in 2572. (#2615)

* API app cleanup (#2596)

* rm IndexView

* rm SACViewSet

* Bump Actions (#2624)

* Bump to v0.13.0

* Bump setup-node to v4

* Media Backups! (#2610)

* pseudo code for s3 tar implementation

* add awscli to allow list

* File Rename

* All commands

Just need to sort creds now

* update command file

* Update proxy allow list for s3tar

* Script for backing up the media

* chmod +x

* Remove mediabackup

* add media backups

* Bind service with additional instances

* Removing allowlist modifications

* Using this workflow to test/debug

* Update

* Update

* File Rename

* Reformat Media Backups Workflow

* remove media backups from prod (for now)

* Remove mediabackups folder as well

* Remove from apply

This will be handled in its own workflow

* Database and Media Backups

Commented out prod for future iteration

* rename file

* full path of aws (#2636)

* Removing old workbook_generator tool (#2635)

Co-authored-by: Phil Dominguez <“[email protected]”>

---------

Co-authored-by: Dan Swick <[email protected]>
Co-authored-by: Matt Jadud <[email protected]>
Co-authored-by: Hassan D. M. Sambo <[email protected]>
Co-authored-by: Tadhg O'Higgins <[email protected]>
Co-authored-by: James Person <[email protected]>
Co-authored-by: Matt Henry <[email protected]>
Co-authored-by: Matt Henry <[email protected]>
Co-authored-by: Tim Ballard <[email protected]>
Co-authored-by: Tim Ballard <[email protected]>
Co-authored-by: James Person <[email protected]>
Co-authored-by: Alex Steel <[email protected]>
Co-authored-by: Phil Dominguez <“[email protected]”>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timoballard timoballard timoballard approved these changes

@heymatthenry heymatthenry Awaiting requested review from heymatthenry

Assignees

@jperson1 jperson1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jperson1 @timoballard