#2671 Added GitHub workflow file for historic data migrator #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Terraform plan for dev No changes. Your infrastructure matches the configuration.✅ Plan applied in Deploy to Development and Management Environment #344 |
|
Terraform plan for meta No changes. Your infrastructure matches the configuration.✅ Plan applied in Deploy to Development and Management Environment #344 |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against a36dbd1 |
asteel-gsa
reviewed
Nov 6, 2023
Co-authored-by: Alex Steel <[email protected]>
asteel-gsa
reviewed
Nov 6, 2023
asteel-gsa
reviewed
Nov 6, 2023
| cf_password: ${{ secrets.CF_PASSWORD }} | ||
| cf_org: gsa-tts-oros-fac | ||
| cf_space: ${{ env.space }} | ||
| command: cf run-task gsa-fac -k 2G -m 2G --name historic_data --command "python manage.py historic-data-migrator --dbkeys ${{ inputs.dbkeys }} --years ${{ inputs.years }}" |
There was a problem hiding this comment.
What happens when this runs as
python manage.py historic-data-migrator --dbkeys --years ?
Since the inputs are not required
There was a problem hiding this comment.
There are default values for these params in the code. A similar workflow is end-to-end-test-data-generator.yml
Co-authored-by: Alex Steel <[email protected]>
asteel-gsa
reviewed
Nov 6, 2023
asteel-gsa
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
LGTM
As a reminder, when running this via workflow:
- cf login -a api.fr.cloud.gov --sso
- Select our org and space
cf logs gsa-fac | grep "APP/TASK/historic_data"orcf logs gsa-fac | grep "APP/TASK/historic_data_migrator"if you change the name to be explicit.- Run workflow
- Periodically check the task with
cf tasks gsa-fac
Co-authored-by: Alex Steel <[email protected]>
sambodeme
deleted the
2671-e2e-refactor-demonstrate-execution-of-code-via-gh-action
branch
asteel-gsa
added a commit
that referenced
this pull request
Nov 7, 2023
* #2671 Added GitHub workflow file for historic data migrator * #2671 Updated ReadMe and workflow * Update .github/workflows/historic-data-migrator.yml Co-authored-by: Alex Steel <[email protected]> * Update .github/workflows/historic-data-migrator.yml Co-authored-by: Alex Steel <[email protected]> * Update .github/workflows/historic-data-migrator.yml Co-authored-by: Alex Steel <[email protected]> --------- Co-authored-by: Alex Steel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2671
Added GitHub Workflow Action for Migrating Historical Data.
dev,stagingandpreviewUpdated READMe
PR checklist: submitters
maininto your branch shortly before creating the PR. (You should also be mergingmaininto your branch regularly during development.)git status | grep migrations. If there are any results, you probably need to add them to the branch for the PR. Your PR should have only one new migration file for each of the component apps, except in rare circumstances; you may need to delete some and re-runpython manage.py makemigrationsto reduce the number to one. (Also, unless in exceptional circumstances, your PR should not delete any migration files.)PR checklist: reviewers
make docker-clean; make docker-first-run && docker compose up; then rundocker compose exec web /bin/bash -c "python manage.py test"The larger the PR, the stricter we should be about these points.