Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perhaps i missed a slash? ngnix is weird #709

Merged
merged 1 commit into from
Dec 21, 2022
Merged

perhaps i missed a slash? ngnix is weird #709

merged 1 commit into from
Dec 21, 2022

Conversation

robert-bryson
Copy link
Contributor

Related to GSA/data.gov#4061

@robert-bryson
Copy link
Contributor Author

I don't know if this is legible, but ngnix playground says this should be working?
image

I think with the extra /, nginx does not pass along the rest of the url. I'm not sure, ngnix is weird.

jbrown-xentity
jbrown-xentity approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@jbrown-xentity jbrown-xentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wish I had more confirmation to add, but I'm not sure either. Looks good.

@robert-bryson robert-bryson merged commit 2407294 into main Dec 21, 2022
@robert-bryson robert-bryson deleted the fix/ngnix-sitemap-config branch December 21, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrown-xentity jbrown-xentity jbrown-xentity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robert-bryson @jbrown-xentity