Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CKAN_SITE_URL urls in sitemap index + refactoring #236

Merged
merged 6 commits into from
Dec 19, 2022
Merged

CKAN_SITE_URL urls in sitemap index + refactoring #236

merged 6 commits into from
Dec 19, 2022

Conversation

robert-bryson
Copy link
Contributor

@robert-bryson robert-bryson commented Dec 16, 2022 •
edited
Loading

Pull Request

Related to GSA/data.gov#4061

About

PR TASKS

  • The actual code changes.
  • Tests written and passed.
  • Any changes to docs?
  • Bumped version number in setup.py (also checked on PyPi).

@robert-bryson robert-bryson marked this pull request as ready for review December 16, 2022 23:20
@robert-bryson robert-bryson mentioned this pull request Dec 19, 2022
Merged
jbrown-xentity
jbrown-xentity reviewed Dec 19, 2022
View reviewed changes
Copy link
Contributor

@jbrown-xentity jbrown-xentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, but can we change how the site_url is integrated? Technically we should get it from CKAN config (either CLI or ckan.ini file), not just the CLI environment...

@robert-bryson
Copy link
Contributor Author

Looks pretty good, but can we change how the site_url is integrated? Technically we should get it from CKAN config (either CLI or ckan.ini file), not just the CLI environment...

Sure, I have been looking into the config object, but don't see an obvious site_url or something. Do you have something in mind that makes the equivalent to CKAN_SITE_URL available?

@jbrown-xentity jbrown-xentity merged commit 42acd86 into main Dec 19, 2022
@jbrown-xentity jbrown-xentity deleted the feature/sitemap-pretty-urls branch December 19, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrown-xentity jbrown-xentity jbrown-xentity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robert-bryson @jbrown-xentity