bug fix; add record status assertion in invalid transform test

GSA · Jan 6, 2025 · 76dcae5 · 76dcae5 · github-actions · Jan 6, 2025
1 parent 53be14b
commit 76dcae5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/harvester/harvest.py b/harvester/harvest.py
@@ -193,7 +193,7 @@ def external_records_to_id_hash(self, records: list[dict]) -> None:
             except Exception as e:
                 # TODO: do something with 'e'
                 raise ExtractExternalException(
-                    f"{self.title} {self.url} failed to convert to id:hash",
+                    f"{self.name} {self.url} failed to convert to id:hash",
                     self.job_id,
                 )
 
@@ -245,7 +245,7 @@ def compare(self) -> None:
         except Exception as e:
             # TODO: do something with 'e'
             raise CompareException(
-                f"{self.title} {self.url} failed to run compare. exiting.",
+                f"{self.name} {self.url} failed to run compare. exiting.",
                 self.job_id,
             )
 

diff --git a/tests/integration/harvest/test_transform.py b/tests/integration/harvest/test_transform.py
@@ -47,6 +47,9 @@ def test_invalid_transform_iso19115_2(
         assert len(job_errors) == 1
         assert job_errors[0].message == expected_error_msg
 
+        record = interface.get_harvest_record(job_errors[0].record.id)
+        assert record.status == "error"
+
     def test_valid_transform_iso19115_2(
         self,
         interface,