Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fed & non-fed dcatus1.1 schemas #114

Merged
merged 2 commits into from
Nov 22, 2024
Merged

add fed & non-fed dcatus1.1 schemas #114

merged 2 commits into from
Nov 22, 2024

Conversation

rshewitt
Copy link
Contributor

Pull Request

Related to #4870

About

PR TASKS

  • The actual code changes.
  • Tests written and passed.
  • Any changes to docs?

@rshewitt rshewitt requested a review from a team November 21, 2024 18:16
Copy link
Contributor

@jbrown-xentity jbrown-xentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
In the old version, we had a federal and non-federal catalog and single item definitions: https://github.com/GSA/ckanext-datajson/tree/main/ckanext/datajson/pod_schema/non-federal-v1.1
I think in the new version, that is unnecessary. The only difference is the single item definitions. However, how can we have a catalog schema that points to either federal or non-federal, depending upon the use case, without duplicating the catalog JSON schema definition for both use cases? I'm happy to discuss further in person if necessary.

@rshewitt
Copy link
Contributor Author

Looks good! In the old version, we had a federal and non-federal catalog and single item definitions: https://github.com/GSA/ckanext-datajson/tree/main/ckanext/datajson/pod_schema/non-federal-v1.1 I think in the new version, that is unnecessary. The only difference is the single item definitions. However, how can we have a catalog schema that points to either federal or non-federal, depending upon the use case, without duplicating the catalog JSON schema definition for both use cases? I'm happy to discuss further in person if necessary.

the harvest runner currently only validates using the single item definition. we don't use the catalog schema. are we intending on doing that?

@rshewitt rshewitt merged commit 15b3c46 into main Nov 22, 2024
4 checks passed
@rshewitt rshewitt deleted the add-non-federal-dcatus branch November 22, 2024 17:15
@jbrown-xentity
Copy link
Contributor

Looks good! In the old version, we had a federal and non-federal catalog and single item definitions: https://github.com/GSA/ckanext-datajson/tree/main/ckanext/datajson/pod_schema/non-federal-v1.1 I think in the new version, that is unnecessary. The only difference is the single item definitions. However, how can we have a catalog schema that points to either federal or non-federal, depending upon the use case, without duplicating the catalog JSON schema definition for both use cases? I'm happy to discuss further in person if necessary.

the harvest runner currently only validates using the single item definition. we don't use the catalog schema. are we intending on doing that?

Nope. So you're good, good point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants