SRCH-1756 add additional specs #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove fuubar gem - install shoulda gem
MothOnMars
commented
Dec 1, 2020
| @@ -310,6 +319,39 @@ | |||
|
|
|||
| it_behaves_like 'a data modifying request made during read-only mode' | |||
| end | |||
|
|
|||
| context 'when time has passed since the document was created' do | |||
There was a problem hiding this comment.
I'm deliberately adding this as an integration spec. Currently this functionality come courtesy of a gem that we're about to remove, so I feel more confident testing this at the integration level, so that the spec is not dependent on any low-level implementation.
jmax-fearless
approved these changes
Dec 2, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some unit tests to simplify the upgrade process. (This repo is heavy on integration specs, light on unit specs.)