-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Website]: Code examples and samples require JavaScript #37
Comments
Created a Created a
|
@joshbruce I have covered till inlinefeedbackform_quick! Will commit shortly! |
@anuragmundada-reisys - Sweet! That is so awesome. Thank you so much. I'm going to remove the JS file on my next one. I love when meetings get cancelled. 👍 |
[Website]: [Pagination, nameform, addressform, signinform, registration, feedback form] new pattern #37
@diego-ruiz-rei & @anuragmundada-reisys - Merged and site updated for end of Sprint demo. Think this could totally be something you demo. Thanks again! |
Issue type
This is a duplication of the one from the UWDS: uswds/uswds#1305
What happened
The code samples are generated after page load. There is a JS function that checks for a
div
with classpreview
. It copies the contents, inserts them into a string. Then adds the element to the page.Therefore, if JS fails or is disabled the code sample boxes don't show up. See the 18f ticket.
What I expected
Code samples would always be displayed. We can make this part of the Jekyll build - see the solution for the USWDS. It would change the file structure a bit, and make defining a component a little more interesting.
Steps to reproduce the issue [optional]
ps. I wasn't sure if this would be a level 1 or 2 defect as they both apply; however, the dependency on JavaScript means it match our definition of done.
The text was updated successfully, but these errors were encountered: