Port to gnome 44 #1577
Port to gnome 44 #1577
Conversation
|
I spent some time reading the gnome-shell code - as far as I can tell there is no good solution for inserting the quick toggle reliably before the 'Background Apps' QuickSettingsItem. Other than that this patch is working fine on Gnome 44 :) |
| @@ -41,7 +41,7 @@ const ServiceToggle = GObject.registerClass({ | |||
|
|
|||
| _init() { | |||
| super._init({ | |||
| label: 'GSConnect', | |||
| title: 'GSConnect', | |||
There was a problem hiding this comment.
This breaks compatibility for GNOME 43 despite 43 being included as supported in the extension metadata
There was a problem hiding this comment.
I didn't test yet, thanks for the testing help! In general we only support the latest shell version, so the correct solution is to drop 43 from metadata.json
There was a problem hiding this comment.
Thanks for catching that, I totally missed it. @daniellandau If you have the time to fix the missing icon feel free - otherwise I'll try to come back to this when I have time. :)
should be fixed with the latest commit. Thanks for catching it though!
|
istvan-derda
force-pushed
the
feat/port-to-gnome-44
branch
from
634abe1 to
df34aad
Compare
|
Took a while to manage finding a 'background app', but yes indeed that's a bad place for the quicktoggle. Otherwise looking really good and I understood in Matrix that you should have an idea already on how to fix it. (Might want to contribute the fix to caffeine too BTW) |
Yes, @andyholmes helped me out there. That behavior is now fixed :) |
istvan-derda
force-pushed
the
feat/port-to-gnome-44
branch
from
cf1abee to
25b3fb4
Compare
Add missing semicolon Co-authored-by: DaPigGuy <[email protected]>
|
LGTM, let's merge this so we can get some testing before Wednesday when GNOME 44 drops. Thanks for the work everyone! |
This patch intends to add support for gnome 44 and is very much work in progress. If you don't want WIP PRs in the repo, I'll happily retract it and submit when I'm ready. I don't have much experience with contributing to open source, not 100% sure about the ins and outs.
Status of the PR:
❗
The QuickToggle is appended after the 'Background Apps' menu item. This looks rather weird, but not outlandish.❗ The QuickToggle is missing the icon it once had. I'm still looking into how it was originally displayed and how to bring it back.Solves #1573