Fix sender parameter of .signal_subscribe #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: this fix is intented for gsconnect users without GNOME installed. Recently, it seems that one cannot acquire a proper sender name automatically when using `dbus-send` command in a Gio.Subprocess. The command is issued in wl_clipboard.js: ``` wl-paste -w dbus-send /org/gnome/Shell/Extensions/GSConnect/Clipboard --dest=org.gnome.Shell.Extensions.GSConnect.Clipboard org.gnome.Shell.Extensions.GSConnect.Clipboard.OwnerChange ``` To fix this issue, we have to set the sender parameter of the method Gio.DBusConnection.signal_subscribe to be null. See docs at: https://docs.gtk.org/gio/method.DBusConnection.signal_subscribe.html
ferdnyc
approved these changes
May 28, 2024
There was a problem hiding this comment.
I'm going to merge this since @JingMatrix says it works, the code looks fine, and even if it isn't the only thing it could possibly break is the CLI mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this fix is intented for gsconnect users without GNOME installed.
Recently, it seems that one cannot acquire a proper sender name automatically when using
dbus-sendcommand in a Gio.Subprocess. The command is issued in wl_clipboard.js:To fix this issue, we have to set the sender parameter of the method Gio.DBusConnection.signal_subscribe to be null.
See docs at: https://docs.gtk.org/gio/method.DBusConnection.signal_subscribe.html