fix DarkSteel and other EIO items display #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DarkSteel tools and armors implement their
isDamaged()
method as returning a constantfalse
, causinghandleDefault
to return null on such items whenShowWhenFull
config set to true.In order not to add a extra check for
handleDefault
, changes are made insidehandleDarkSteelItems
method.Other possible, but in my opinion, problematic fixes are there.
false
might be intended for other uses which is far beyond my knowing.handleDefault
to check item damage by comparing max and current, but other mods might override theisDamaged
method too to do something else.As a result this PR might seem more complex then it might should have been.