This repository has been archived by the owner on Dec 29, 2024. It is now read-only.
Fix Digester & Dissolution Tank NEI previews #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlueWeabo
approved these changes
Jan 20, 2024
|
The dissolution tank does not need a muffler. It does not produce pollution. Edit: done #85 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ofHatchAdder defaults to IStructureElementNoPlacement as opposed to IStructureElement if no shouldSkip predicate is defined. This doesn't allow the hatches to be placed in survival mode which BlockRenderer respects and causes no hatches to be shown in NEI.
Using the buildHatchAdder method we can do that a bit easier. This also lets the hologram projector place the hatches which leaves less guesswork for the players.
Closes: GTNewHorizons/GT-New-Horizons-Modpack#15341