Skip to content
This repository has been archived by the owner on Dec 29, 2024. It is now read-only.

Migrate dissolution tank & digester to processingLogic #86

Merged
merged 6 commits into from
Feb 18, 2024

Conversation

GDCloudstrike
Copy link
Member

Migrates both multis to processingLogic so features like batch mode & void protection are available

@Dream-Master Dream-Master requested a review from a team February 12, 2024 19:47
@Elisis
Copy link
Member

Elisis commented Feb 14, 2024

Does batch mode work as expected with the dissolution tank's input ratio logic?

@GDCloudstrike
Copy link
Member Author

Does batch mode work as expected with the dissolution tank's input ratio logic?

yes, as it checks for the ratio between the 2 fluids and not their absolute values
the only change in behaviour is that instead of voiding the recipe if the ratios aren't correct, the machine now just doesnt start

image

@AbdielKavash
Copy link
Member

the only change in behaviour is that instead of voiding the recipe if the ratios aren't correct, the machine now just doesnt start

Doesn't that essentially invalidate the automation challenge with it? As long as the player inputs fluid slow enough, one bucket at a time, will the DT simply start when the correct ratio is reached?

@GDCloudstrike
Copy link
Member Author

the only change in behaviour is that instead of voiding the recipe if the ratios aren't correct, the machine now just doesnt start

Doesn't that essentially invalidate the automation challenge with it? As long as the player inputs fluid slow enough, one bucket at a time, will the DT simply start when the correct ratio is reached?

WIth the current implementation that is the case, yes. If this is not wanted I can make it void and stop again.

@Elisis
Copy link
Member

Elisis commented Feb 17, 2024

the only change in behaviour is that instead of voiding the recipe if the ratios aren't correct, the machine now just doesnt start

Doesn't that essentially invalidate the automation challenge with it? As long as the player inputs fluid slow enough, one bucket at a time, will the DT simply start when the correct ratio is reached?

WIth the current implementation that is the case, yes. If this is not wanted I can make it void and stop again.

Yeah if you could do that, that'd be more in line with how the multi's meant to behave.

@Dream-Master Dream-Master merged commit 2a7811c into master Feb 18, 2024
2 checks passed
@Dream-Master Dream-Master deleted the lanth_processingLogic branch February 18, 2024 11:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants