Skip to content
This repository has been archived by the owner on Dec 29, 2024. It is now read-only.

Update WerkstoffMaterialPool.java - Fix "Impure Samarium ..." naming #88

Merged
merged 5 commits into from
May 10, 2024

Conversation

Speecker
Copy link

@Speecker Speecker commented May 9, 2024

Renamed "Impure Samarium Oxalate" -> "Coarse Samarium Oxalate". Reason: Deny it from entering OreProc Systems utilizing "dustImpure*" filtering to gather any Impure Dust that can be centrifuged - but Impure Samarium Oxalate needs a Chemical Reactor instead !

Renamed "Impure Samarium Oxalate" -> "Coarse Samarium Oxalate".
Reason: Deny it from entering OreProc Systems utilizing "dustImpure*" filtering to gather any Impure Dust that can be centrifuged - but Impure Samarium Oxalate needs an LSC instead !
@Speecker Speecker changed the title Update WerkstoffMaterialPool.java Update WerkstoffMaterialPool.java - "Impure Samarium Oxalate" -> "Coarse Samarium Oxalate" May 9, 2024
@Dream-Master Dream-Master requested review from Elisis and a team May 9, 2024 17:09
@Dream-Master
Copy link
Member

@Speecker if it is more accurate naming i have nothing against it.

@Speecker
Copy link
Author

Speecker commented May 9, 2024

@Speecker if it is more accurate naming i have nothing against it.

I thought about dustDirtySamarium as well but sure i mean it can be anything else but not dustImpureSamarium as it conflicts with filtering by dustImpure* because it cant be processed by centrifuges :)
What more accurate naming would you suggest then ?
May i edit it to what you prefer as naming instead ?

@Speecker Speecker changed the title Update WerkstoffMaterialPool.java - "Impure Samarium Oxalate" -> "Coarse Samarium Oxalate" Update WerkstoffMaterialPool.java - Fix "Impure Samarium Oxalate" conflict May 9, 2024
@Speecker
Copy link
Author

Speecker commented May 10, 2024

Or maybe just remove the Impure infront entirely as Sm2(C2O4)3 is just Samarium(III) Oxalate (a salt of samarium) and there is no impure or so and there may be no reason to have an Impure Dust of it if there is no "regular" one ?
Same with Samarium(III)-Chlorid - SmCI3 (not SmC13).
But im no chemist by any means.

@Speecker Speecker changed the title Update WerkstoffMaterialPool.java - Fix "Impure Samarium Oxalate" conflict Update WerkstoffMaterialPool.java - Fix "Impure Samarium ..." naming May 10, 2024
@Elisis
Copy link
Member

Elisis commented May 10, 2024

Should probably remove the question marks in front of the chemical formulae as well

@Dream-Master Dream-Master merged commit cfdc7a5 into GTNewHorizons:master May 10, 2024
1 check passed
@Speecker Speecker deleted the patch-1 branch May 10, 2024 13:41
Dream-Master pushed a commit that referenced this pull request May 19, 2024
…88)

* Update WerkstoffMaterialPool.java

Renamed "Impure Samarium Oxalate" -> "Coarse Samarium Oxalate".
Reason: Deny it from entering OreProc Systems utilizing "dustImpure*" filtering to gather any Impure Dust that can be centrifuged - but Impure Samarium Oxalate needs an LSC instead !

* Update WerkstoffMaterialPool.java

* Update WerkstoffMaterialPool.java

* update

* if a material was renamed you need to check the usage

---------

Co-authored-by: Martin Robertz <[email protected]>
(cherry picked from commit cfdc7a5)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants