Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Capability system #112

Merged
merged 6 commits into from
Feb 16, 2025
Merged

Introduce Capability system #112

merged 6 commits into from
Feb 16, 2025

Conversation

miozune
Copy link
Member

@miozune miozune commented Feb 6, 2025

This PR introduces Capability system.

For those who don't know about Capability

Please read Javadoc. If there's anything unclear, feel free to ask questions.

For those who are familiar with Capability in later MC versions

This PR was originally based on 1.12.2 Forge implementation. After that Raven's suggestion drastically simplified it. Now Capability class is gone and there're only CapabilityProvider and Capabilities.

Side note, due to skill issue I used generative AI to generate documents. While I used multiple models, read everything they outputted and tweaked sentences, there could still be oddities.

Copy link
Member

@eigenraven eigenraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs definitely need rewording as they're quite confusing in places, I'll try to do it later today

@Caedis
Copy link
Member

Caedis commented Feb 6, 2025

Some examples like for some vanilla stuff would be useful

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Warning: 2 uncommitted changes
pull request create failed: GraphQL: Head sha can't be blank, Base sha can't be blank, Head repository can't be blank, No commits between GTNewHorizons:feature/capability and origin:GTNewHorizons-feature/capability-spotless-fixes, Head ref must be a branch, not all refs are readable (createPullRequest)

@GlodBlock GlodBlock requested a review from eigenraven February 14, 2025 13:06
@miozune
Copy link
Member Author

miozune commented Feb 15, 2025

Now it's reworked and significantly simplified thanks to Raven. Please take another look.

Some examples like for some vanilla stuff would be useful

As written on Javadoc, usage of vanilla/Forge interfaces as capability is discouraged.

@miozune miozune requested a review from a team February 15, 2025 13:01
@miozune miozune merged commit c70e7b9 into master Feb 16, 2025
1 check passed
@miozune miozune deleted the feature/capability branch February 16, 2025 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants