Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always check for @Config.Ignore before processing field #71

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Always check for @Config.Ignore before processing field #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/main/java/com/gtnewhorizon/gtnhlib/config/ConfigurationManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,10 @@ private static void processConfigInternal(Class<?> configClass, String category,
|| foundCategory && cat.requiresWorldRestart();

for (val field : configClass.getDeclaredFields()) {
if (field.isAnnotationPresent(Config.Ignore.class)) {
continue;
}

if (instance != null && Modifier.isStatic(field.getModifiers())) {
throw new ConfigException(
"Illegal config field: " + field.getName()
Expand All @@ -178,10 +182,6 @@ private static void processConfigInternal(Class<?> configClass, String category,
+ ": Static field in instance context! Did you forget an @Config.Ignore annotation?");
}

if (field.getAnnotation(Config.Ignore.class) != null) {
continue;
}

field.setAccessible(true);

if (!ConfigFieldParser.canParse(field)) {
Expand Down