fix GT bug that spawns a water source when breaking ice with a saw/ch… #103
Conversation
| @@ -9,6 +9,7 @@ | |||
|
|
|||
| public enum Mixins { | |||
| // Vanilla Fixes | |||
| FIX_SAW_ICE_BREAK("minecraft.MixinBlockIce", () -> true, TargetedMod.VANILLA), | |||
There was a problem hiding this comment.
Please make this mixin optional, like all others
There was a problem hiding this comment.
It fixes a water dupe bug, why make it optional ?
There was a problem hiding this comment.
Because A) it is good practice and B) this will throw an ClassNotFoundException if GregTech is not installed
There was a problem hiding this comment.
People outside of the pack use hodgepodge, and I'll likely be pushing it to CF/Modrinth. All patches need to be configurable. This patch should also depend on GT, not vanilla.
| if (itemStack == null | ||
| || !(itemStack.getItem() instanceof GT_MetaGenerated_Tool) | ||
| || !(((GT_MetaGenerated_Tool) itemStack.getItem()).getToolStats(itemStack) instanceof GT_Tool_Saw)) { | ||
| return instance.setBlock(x, y, z, block); |
There was a problem hiding this comment.
I think this will cause an infinite loop and end in an StackOverflowError
There was a problem hiding this comment.
I tested in full pack and no errors, works as intended
|
need to close this once it's merged GTNewHorizons/GT-New-Horizons-Modpack#11240 |
…ainsaw