Added a debug command and some logging to the RC anchors reloading #17
Conversation
| l.add("anchordebug"); | ||
| } else if (test.equals("anchor")) { | ||
| String test1 = ss[1].trim(); | ||
| if (test1.isEmpty() || "list".startsWith(test1)) |
There was a problem hiding this comment.
Missing a check for situation, where admin types /hp anchor list then press tab, expecting to see a list of usernames as completion.
FYI use getListOfStringsMatchingLastWord(as, MinecraftServer.getServer().getAllUsernames()) to quickly get a list of possible completions of username.
| private void printHelp(ICommandSender sender) { | ||
| sender.addChatMessage(new ChatComponentText("Usage: hp <toggle|anchor>")); | ||
| sender.addChatMessage(new ChatComponentText("\"toggle anchordebug\" - toggles RC anchor debugging")); | ||
| sender.addChatMessage(new ChatComponentText("\"anchor list <player>\" - list RC anchors placed by the player (empty for current player)")); |
There was a problem hiding this comment.
Could have been "\"anchor list [player]\" - list RC anchors placed by the player (empty for current player)"
| return; | ||
| } | ||
| String playerName = strings.length > 2 ? strings[2] : sender.getCommandSenderName(); | ||
| if (!AnchorAlarm.listSavedAnchors(playerName, sender.getEntityWorld())) |
There was a problem hiding this comment.
I usually use net.minecraft.server.management.ServerConfigurationManager#playerEntityList to find out all players. Not sure if these are equivalent, just saying.
There was a problem hiding this comment.
getAllUsernames literally calls serverConfigurationManager
|
oh i was to fast ? |
|
nothing game breaking. could be in another PR. |
No description provided.