Add mixin for longer chat messages

[serenibyss]

Adds a two class mixin to allow raising the chat message length limit up to (currently) 512. Newer versions of Minecraft raised this limit to 256, so that is what I chose as the default value. The 512 limit is arbitrary, and I'm not sure if there are larger implications of it being this high, or if it could be higher.

I'm not the most familiar with mixin, so please let me know if there is any problems with remapping especially since I used a deobfuscated name in two of the mixin targets.

[boubou19]

what happens if server and client have different values? Or if 2 clients haven't the same value?

[serenibyss]

what happens if server and client have different values? Or if 2 clients haven't the same value?

This is a problem, as if the server's value is smaller than the client, and the client sends a message that's too long, it will kick the client from the server. I think there's 2 different approaches to handling it, either just force the chat length to 256 like newer Minecraft versions (or some other agreed upon number), or somehow synchronize the server config value to the client on join (not sure how easy this is)

[boubou19]

imo best would be for clients to be able to automatically break down chat messages into multiple ones if they have a value below the server one

[Alexdoru]

what happens if server and client have different values? Or if 2 clients haven't the same value?

there is no problem if two clients have different values, but it will shorten the message to the server value if the server and client have different values

[Alexdoru]

what happens if server and client have different values? Or if 2 clients haven't the same value?

This is a problem, as if the server's value is smaller than the client, and the client sends a message that's too long, it will kick the client from the server. I think there's 2 different approaches to handling it, either just force the chat length to 256 like newer Minecraft versions (or some other agreed upon number), or somehow synchronize the server config value to the client on join (not sure how easy this is)

imo should just remove the config option to choose the lenght and hardcode it to 256

[Alexdoru]

Adds a two class mixin to allow raising the chat message length limit up to (currently) 512. Newer versions of Minecraft raised this limit to 256, so that is what I chose as the default value. The 512 limit is arbitrary, and I'm not sure if there are larger implications of it being this high, or if it could be higher.

I'm not the most familiar with mixin, so please let me know if there is any problems with remapping especially since I used a deobfuscated name in two of the mixin targets.

I pushed two commits to correct your pr

[Alexdoru]

I'm ok with this now if anyone else wants to look at it

You said you ok with it

[Dream-Master]

@serenibyss

[serenibyss]

If the server has the setting off, and a client joins with the setting on, it would still disconnect the player if an oversized message is sent

[Dream-Master]

@serenibyss are there any way to fix it?

[Dream-Master]

@serenibyss can you resolve the conflict?

[github-actions]

Warning: 2 uncommitted changes
#274

[Caedis]

I believe that is the proper way to add config syncing.
Logged on the sp dev world and I could send messages > 100 characters.
Logged on the dev server with the server's config being false and the clients being true and watched it sync the value.
That then prevented sending a message over 100 characters.

This should also allow for future (or current) config options to be synced.

[Alexdoru]

Since I never worked with custom packets, I can't review that PR sorry, but I am glad you could figure it out :p

Implemented and approved changes by miozune