Cleanup ASM/mixins coremods #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does it still works with optifine? I've seen optifine something in the file history so it might be interfering. |
nothing injects in the RenderBlocks class when optifine is present, I'll try to change it |
|
we work with optifine now |
Caedis
approved these changes
Nov 3, 2023
|
Please do not use & in branch names |
auto-merge was automatically disabled
November 3, 2023 23:44
Rebase failed
…SM wasn't injecting out of dev env
…at have 0 effects on the server
…use of a mixin bug
…when registering new mixins
Alexdoru
force-pushed
the
asm&mixin-cleanup
branch
from
bc7552e to
303ef5a
Compare
|
I rebased on top of master locally as well as squashed a bunch of commits together to clean the git log, I made sure it builds and runs, but I might have introduced some errors in the process if someone could double check that would be nice :p |
|
I was double checking it just now lol |
|
Builds and launches without issue on my end btw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup asm transformers
Translate GT Pollution ASM transformers to mixins
Fix optifine support for GT Pollution mixins
Now require devs to set Phase and Side when registering mixins to avoid mistakes and crashes in production
All the pollutions related byecode manipulation stuff is now in mixins form and should be moved to GT5U in a later PR