Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CV support to wand recharge pedestal #32

Merged
merged 3 commits into from
Nov 11, 2021
Merged

Add CV support to wand recharge pedestal #32

merged 3 commits into from
Nov 11, 2021

Conversation

repo-alt
Copy link
Contributor

No description provided.

@repo-alt repo-alt requested a review from a team November 10, 2021 17:00
@repo-alt repo-alt marked this pull request as draft November 10, 2021 18:00
@repo-alt repo-alt marked this pull request as ready for review November 10, 2021 18:58
@repo-alt repo-alt requested a review from Glease November 10, 2021 18:58
@Glease
Copy link
Contributor

Glease commented Nov 10, 2021

Wait a sec, it appears ItemWandCasting.addRealVis() is really ItemWandCasting.addCentiVis(), and that parameter actually means cvAmount not visAmount.

@repo-alt
Copy link
Contributor Author

Ok, it turns out the wands store CV inside.

Glease
Glease approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@Glease Glease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@Dream-Master Dream-Master merged commit bbfb7fa into GTNewHorizons:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Glease Glease Glease approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@repo-alt @Glease @Dream-Master