Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 1.20's 'pause-when-empty-seconds' server property #470

Merged
merged 12 commits into from
Jan 13, 2025
Merged

Conversation

Caedis
Copy link
Member

@Caedis Caedis commented Jan 9, 2025

Change from modern: default value of pause-when-empty-seconds is 0 which means the server wont pause.

Tested in a dev server with a value of 5.

Ticks stopped after 5 seconds, resumed when there was a connection and then stopped again when empty after 5 seconds.

Added command /hp pauseWhenEmpty <seconds>

image
image
image

@Caedis Caedis requested a review from a team January 9, 2025 21:26
@Caedis
Copy link
Member Author

Caedis commented Jan 9, 2025

Works in full pack
image

@Caedis Caedis marked this pull request as draft January 9, 2025 21:57
@Caedis Caedis marked this pull request as ready for review January 9, 2025 22:33
@Caedis Caedis requested review from Lyfts and embeddedt January 9, 2025 22:33
@Caedis Caedis marked this pull request as draft January 9, 2025 22:48
@Caedis Caedis marked this pull request as ready for review January 9, 2025 23:55
@Caedis
Copy link
Member Author

Caedis commented Jan 9, 2025

Thought it was causing issues loading the pack

Copy link
Contributor

@embeddedt embeddedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Caedis Caedis requested a review from a team January 10, 2025 01:32
@Caedis
Copy link
Member Author

Caedis commented Jan 11, 2025

Replaced itzg's docker-minecraft-server's auto pause with this and while it doesnt fully pause the java process, its been running without issue.

@serenibyss serenibyss merged commit 6aaff70 into master Jan 13, 2025
2 checks passed
@serenibyss serenibyss deleted the pausing branch January 13, 2025 07:21
Caedis added a commit that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants