Jabba performance adjust #5
Merged
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
4M is far too low for a new default. |
|
Changed to distance of 100 as default |
1 similar comment
|
Changed to distance of 100 as default |
draknyte1
approved these changes
Aug 10, 2020
hazzal
reviewed
Aug 10, 2020
| @@ -129,7 +129,7 @@ public void preInit(FMLPreInitializationEvent event) { | |||
|
|
|||
| allowOreDictUnification = config.getBoolean("allowOreDictUnification", Configuration.CATEGORY_GENERAL, true, "If true, Jabba will try unificate 'ingot' 'ore' 'dust' and 'nugget' using oredict"); | |||
|
|
|||
| renderDistance = config.getFloat("renderDistance", Configuration.CATEGORY_GENERAL, 16f, 0f, 10000f, "Render Distance (square) for stack and text on barrel."); | |||
| renderDistance = config.getFloat("renderDistance", Configuration.CATEGORY_GENERAL, 10000f, 0f, 10000f, "Render Distance (square) for stack and text on barrel."); | |||
There was a problem hiding this comment.
Can we change the text for the config to describe that it is actually cubed (not squared) distance.
Please disregard, thankfully Glease corrected my wrong interpretation.
There was a problem hiding this comment.
No. Check the code again. It is indeed squared.
There was a problem hiding this comment.
Apologies in that case. Please disregard my initial comment and thanks for correcting me Glease
|
@TataTawa @draknyte1 @hazzal can we merge it ? |
|
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5% fps increase if you have 50 jabba barrels in your render distance. This change actually makes the item and text on the barrel not rendering when the player is far (4m default). and this could be configurable.