Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed 4096 insertions of EnderStorage EnderChest #7

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

TimeConqueror
Copy link
Contributor

@TimeConqueror TimeConqueror commented Aug 5, 2021

So originally this loop was created because author wanted to add all Ender Chests from EnderStorage to the BSpace Recipe. He didn't do this with wildcard (as done now), because Ender Chest and Ender Tank share the same item, so the recipe didn't want to accept tanks (item with meta > 4096).

But I changed it back to WILDCARD, because:

  1. It speeds up the modpack loading by 6 seconds.
  2. 4096 excess items were removed from OreDictionary.
  3. The recipe was overriden in GTNH, so actually, the players won't notice any change.
  4. Ender Tank has almost the same recipe, so why not to use it as well? (moreover, it allows to use vanilla EnderChest)

@TimeConqueror TimeConqueror requested a review from a team August 5, 2021 21:46
@Dream-Master Dream-Master merged commit c7108c4 into master Aug 6, 2021
@Dream-Master Dream-Master deleted the great-speed-up branch August 6, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants