-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of Blood Magic Frames #20
Conversation
Adds the replacement for the Blood Frame from BM, which is soon to be deleted from BM because of glitches, likewise this adds a new frame, The Maddening Frame of Frenzy, both use LP, both need a recipe to be decided on a later date, both need their lp tweaked, the updated LP is currently proposed to be switched to 25k
Warning: 2 uncommitted changes |
Before we merge this please add tooltips to the frames . |
|
@Alastors your pr not build maybe you need to add MB to it ? |
This is magic bees though? The issue is specific to GitHub and I don't know what's happening here? |
The only thing that has worked so far is making BM a hard dependency and that's kind of cringe |
Fix it we can not merge it before |
Working on it, it's 3 am where I am rn so I'll get to it in the morning |
Aight, I figured out how to fix it, but Kuba's gonna hate it, the helper being in the helper list is literally what's breaking everything |
src/main/java/magicbees/main/utils/compat/ThaumcraftHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/magicbees/main/utils/compat/ThaumcraftHelper.java
Outdated
Show resolved
Hide resolved
Thank you for your help Kuba, I do genuinely appreciate the fuck out of it, even if I don't act like it sometimes |
There of course will need to be further balancing in the future, but I have handled this PR to the absolute best of my ability, and as I have little to no experience with BM within GTNH as a whole, I have no true ability to balance the passive LP cost by myself, as such I think we should let this out as it is, and balance as we get responses out in the wild.
src/main/java/magicbees/main/utils/compat/bloodmagic/ItemBloodFrame.java
Outdated
Show resolved
Hide resolved
src/main/java/magicbees/main/utils/compat/bloodmagic/ItemBloodBaseFrame.java
Outdated
Show resolved
Hide resolved
src/main/java/magicbees/main/utils/compat/bloodmagic/ItemBloodBaseFrame.java
Outdated
Show resolved
Hide resolved
src/main/java/magicbees/main/utils/compat/bloodmagic/ItemBloodBaseFrame.java
Outdated
Show resolved
Hide resolved
src/main/java/magicbees/main/utils/compat/bloodmagic/ItemBloodFrame.java
Outdated
Show resolved
Hide resolved
src/main/java/magicbees/main/utils/compat/bloodmagic/ItemBloodFrame.java
Outdated
Show resolved
Hide resolved
src/main/java/magicbees/main/utils/compat/bloodmagic/ItemFrenziedFrame.java
Outdated
Show resolved
Hide resolved
src/main/java/magicbees/main/utils/compat/bloodmagic/ItemFrenziedFrame.java
Outdated
Show resolved
Hide resolved
src/main/java/magicbees/main/utils/compat/bloodmagic/ItemFrenziedFrame.java
Outdated
Show resolved
Hide resolved
Warning: 2 uncommitted changes |
Spotless apply for branch Blood-Frames for #20
I'll put this out here and be done with it, I have no ability to test this on multiplayer currently, someone else would need to do that as such. |
Adds the replacement for the Blood Frame from BM, which is soon to be deleted from BM because of glitches.
Likewise this adds a new frame, The Maddening Frame of Frenzy,
this has a mutation rate of 10, and a genetic decay of 10 and a durability of 1,
but consumes LP instead of durability when applicable.
Both use LP, both need a recipe to be decided on a later date,
both need their lp tweaked,
the updated LP is currently proposed to be switched to 25k.
They take LP directly from the player network.