Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of Blood Magic Frames #20

Merged
merged 72 commits into from
Apr 30, 2023
Merged

Addition of Blood Magic Frames #20

merged 72 commits into from
Apr 30, 2023

Conversation

Alastors
Copy link

@Alastors Alastors commented Apr 28, 2023

Adds the replacement for the Blood Frame from BM, which is soon to be deleted from BM because of glitches.

Likewise this adds a new frame, The Maddening Frame of Frenzy,
this has a mutation rate of 10, and a genetic decay of 10 and a durability of 1,
but consumes LP instead of durability when applicable.

Both use LP, both need a recipe to be decided on a later date,
both need their lp tweaked,
the updated LP is currently proposed to be switched to 25k.
They take LP directly from the player network.

Screen_Shot_2023-04-27_at_2 06 04_PM

Screen_Shot_2023-04-27_at_2 06 27_PM

Screen_Shot_2023-04-27_at_2 06 18_PM

Adds the replacement for the Blood Frame from BM, which is soon to be deleted from BM because of glitches, likewise this adds a new frame, The Maddening Frame of Frenzy, both use LP, both need a recipe to be decided on a later date, both need their lp tweaked, the updated LP is currently proposed to be switched to 25k
@github-actions
Copy link

Warning: 2 uncommitted changes
#21

@GTNewHorizons GTNewHorizons deleted a comment from github-actions bot Apr 28, 2023
@Dream-Master
Copy link
Member

Before we merge this please add tooltips to the frames .

Alastors added a commit to GTNewHorizons/GT-New-Horizons-Modpack that referenced this pull request Apr 28, 2023
@Alastors
Copy link
Author

Before we merge this please add tooltips to the frames .

GTNewHorizons/GT-New-Horizons-Modpack#13343

@Dream-Master
Copy link
Member

@Alastors your pr not build maybe you need to add MB to it ?

@Alastors
Copy link
Author

@Alastors your pr not build maybe you need to add MB to it ?

This is magic bees though? The issue is specific to GitHub and I don't know what's happening here?

@Alastors
Copy link
Author

The only thing that has worked so far is making BM a hard dependency and that's kind of cringe

@Dream-Master
Copy link
Member

Fix it we can not merge it before

@Alastors
Copy link
Author

Fix it we can not merge it before

Working on it, it's 3 am where I am rn so I'll get to it in the morning

@Alastors
Copy link
Author

Aight, I figured out how to fix it, but Kuba's gonna hate it, the helper being in the helper list is literally what's breaking everything

src/main/java/magicbees/main/utils/compat/BloodHelper.java Outdated Show resolved Hide resolved
src/main/java/magicbees/main/utils/compat/BloodHelper.java Outdated Show resolved Hide resolved
src/main/java/magicbees/main/Config.java Outdated Show resolved Hide resolved
src/main/java/magicbees/main/Config.java Outdated Show resolved Hide resolved
src/main/java/magicbees/main/Config.java Outdated Show resolved Hide resolved
src/main/java/magicbees/main/utils/compat/BloodHelper.java Outdated Show resolved Hide resolved
src/main/java/magicbees/main/utils/compat/BloodHelper.java Outdated Show resolved Hide resolved
src/main/java/magicbees/main/utils/compat/BloodHelper.java Outdated Show resolved Hide resolved
@Alastors
Copy link
Author

Thank you for your help Kuba, I do genuinely appreciate the fuck out of it, even if I don't act like it sometimes

@kuba6000 @firenoo holy christ guys, we've actually finally fixed this piece of crap, it took 2 grueling days, but we actually fixed the thing.
There of course will need to be further balancing in the future, but I have handled this PR to the absolute best of my ability, and as I have little to no experience with BM within GTNH as a whole, I have no true ability to balance the passive LP cost by myself, as such I think we should let this out as it is, and balance as we get responses out in the wild.
@Alastors Alastors marked this pull request as ready for review April 30, 2023 02:06
@github-actions
Copy link

Warning: 2 uncommitted changes
#25

@Alastors
Copy link
Author

I'll put this out here and be done with it, I have no ability to test this on multiplayer currently, someone else would need to do that as such.

@Dream-Master Dream-Master merged commit 3d562d0 into master Apr 30, 2023
@Dream-Master Dream-Master deleted the Blood-Frames branch April 30, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants