Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all ASM from MalisisCore(literally none of it was needed or provided any functionality to MalisisDoors, who could've guessed).
Additionally, this converts most of the reflection which was used to access private fields to use Access Transformers, and improves the remaining reflection that couldn't use access transformers to use
MethodHandle
objects andinvokeExact
instead of working directly on reflected fields.I've tested the special doors like big doors, garage door, saloon doors, and nothing is broken with them due to removing the ASM. I've also tested a few of the standard doors built from the door factory and haven't found anything broken with them as a result of this.