Port of Holo-Inventory, SpiceOfLife, BiblioCraft and sleeping bags scripts into code. #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires:
For the biobliocraft/bibliowoods stuff, it needs extensive testing, as i translated the script into java via a python script, so idk if everything went well, but i didn't spot any error. But i remember that @Dream-Master told me that after the sledgehammer, some bibliocraft stuff is missing recipes.
Let me know which recipes and i'll add them back. I also didn't cached at all the lookups in the gameregistry for the item/blocks from other mods, so this definitely can be improved. But for now, i want to focus on the script port.