Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subset Widget Improvement #577

Merged
merged 9 commits into from
Jan 16, 2025

Conversation

slprime
Copy link
Member

@slprime slprime commented Dec 24, 2024

Now subsets can be drawn together with bookmarks

label image
settings image
on top image
on bottom image

Added Hotkeys tooltips

subset item
image image

Cleanup NEI layout

before after
image image

Issue:

GTNewHorizons/GT-New-Horizons-Modpack#17600

@Dream-Master Dream-Master requested a review from a team December 24, 2024 19:22
@serenibyss serenibyss added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Dec 29, 2024
Copy link

@OneEyeMaker OneEyeMaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.
My personal suggestion: it would be very nice to replace this dark X label on button with some icon.

src/main/java/codechicken/nei/ItemStackMap.java Outdated Show resolved Hide resolved
src/main/java/codechicken/nei/ItemStackMap.java Outdated Show resolved Hide resolved
src/main/java/codechicken/nei/ItemStackMap.java Outdated Show resolved Hide resolved
@slprime
Copy link
Member Author

slprime commented Jan 16, 2025

Looks good overall. My personal suggestion: it would be very nice to replace this dark X label on button with some icon.
you about this?
image
image

If yes,

not all people fully understand what subsets are that are more than 10 years old. for this reason i decided to draw a symbol that is responsible for the subset. it can be configured through the configuration file and it is different for the old and new search. i also chose the same color that is drawn in the search field

@slprime slprime requested a review from OneEyeMaker January 16, 2025 18:39
@Dream-Master Dream-Master merged commit e357480 into GTNewHorizons:master Jan 16, 2025
1 check passed
@serenibyss serenibyss removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants