Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Permutation Filter #598

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

slprime
Copy link
Member

@slprime slprime commented Jan 25, 2025

I working for Favorites, refactoring Bookmarks Chains, Autocraft and other small features. I have extracted some of the functionality into this PR, to make it easier to test. (PR with 70 files is not a good idea)

1 Accepts following tooltip:
1.1 add selection for active item
1.2 align more marker
1.3 fix permutation items filter
image

2 now the algorithm groups hotkeys by tooltip (Example from another PR. here only new algorithm)
image

3 created missing hiddenhandlers.cfg
4 code cleanup

@slprime slprime requested a review from a team January 25, 2025 17:53
@serenibyss serenibyss added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jan 25, 2025
Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature works great, code looks good

@serenibyss serenibyss removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jan 25, 2025
@serenibyss serenibyss merged commit 0bbb889 into GTNewHorizons:master Jan 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants