Fix health bar renderer #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… vanilla renderHealth method
…asting certain vanilla methods
…raw the top most hearts
|
|
|
I did not know, where is that ? |
|
@Alexdoru nevermind it was the Armor bar not the health bar. https://github.com/GTNewHorizons/OverloadedArmorBar |
mitchej123
approved these changes
Sep 24, 2023
DrParadox7
pushed a commit
to DrParadox7/TinkersConstruct
that referenced
this pull request
May 10, 2024
* delete unused locals * add some code that has been forgotten when copying and overriding the vanilla renderHealth method * create dedicated class HealthBarRenderer extending Gui to stop copy-pasting certain vanilla methods * fix renegeration hearts moving when the game is paused * only bind tinkers hearts textures if it's actually going to draw tinkers' hearts * stop drawing vanilla hearts when they are hidden by tinkers' heart being drawn on top * fix tinker's half heart not moving with regeneration * fix drawing all tinkers' hearts on top of each others, and now only draw the top most hearts * add comment to help with debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tinkers constructs completely overwrites the health bar rendering and there were multiple bugs with it. Notably it was drawing all of the hearts that your character has on top of each other even though you can only see the 10 hearts at the very top, costing performance for nothing.
In this pr I :