-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ability radial menu unexpectedly grabbing focus #3
Conversation
Tested - works. With key it's functionally similar to pre-2.7 (a possible improvement, if possible, is for it to not regrab the cursor to center on clicking on a gear piece so that I can spam left click on gear to quickly forward through states, instead of having to move the mouse back to it every change). With mouse button (button 5), it closes the UI after clicking gear once, making it a bit hard to use. However, it is functional, which is an improvement over being totally broken. |
I've looked into this: the first point I can probably implement, needs a mixin. Will be after 2.7. The second point is a limitation of vanilla (mouse buttons stop reporting after the game releases the mouse pointer) and I don't deem it worth implementing a workaround for it. |
Would appreciate a review to get this in for 2.7. |
if this got reviewed why not rc2 next Weekend |
Sure, however you prefer it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the best at mixin, but it looks like it should work.
When the ability radial menu was bound to a keyboard key, it was challenging to select an ability as the menu would grab the mouse cursor again immediately after opening. This did not affect bindings to mouse buttons.
Couldn't prevent myself from including some simple refactorings as the code wasn't great. This is all in a separate commit. I can drop it in case there are concerns with it in regard to our current dev freeze.
Fixes GTNewHorizons/GT-New-Horizons-Modpack#17347