Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add borderless fullscreen, make fullscreen choose the appropriate monitor #162

Merged
merged 3 commits into from
Jul 27, 2024
Merged

Add borderless fullscreen, make fullscreen choose the appropriate monitor #162

merged 3 commits into from
Jul 27, 2024

Conversation

SKProCH
Copy link
Contributor

@SKProCH SKProCH commented Jul 6, 2024

  • Adds the borderless fullscreen mode, toggleable in config
  • Make fullscreen (and borderless) choose current window monitor (instead of just primary as it is now)

@SKProCH
Copy link
Contributor Author

SKProCH commented Jul 6, 2024

If this PR will be merged - no need for https://github.com/GTNewHorizons/Fullscreen-Windowed-Minecraft, it can be archieved.

@Caedis
Copy link
Member

Caedis commented Jul 6, 2024

might need to be tested with tiling window managers on x11 and wayland

@Dream-Master Dream-Master requested a review from a team July 7, 2024 11:39
@eigenraven eigenraven self-requested a review July 7, 2024 12:02
@eigenraven eigenraven enabled auto-merge (squash) July 27, 2024 09:19
@eigenraven eigenraven merged commit 0e16c68 into GTNewHorizons:master Jul 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eigenraven eigenraven eigenraven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SKProCH @Caedis @eigenraven