Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading corrupted lwjgl3ify-early.json #201

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

YannickMG
Copy link
Contributor

There were 3 reports of this issue in the #help channel. This can happen when the server runs out of space and a zero-length lwjgl3ify-early.json is left behind.

A problem occurred running the Server launcher.java.lang.reflect.InvocationTargetException
        at ...
Caused by: java.lang.NullPointerException: Cannot read field "extensibleEnums" because "cfg" is null
        at System//me.eigenraven.lwjgl3ify.rfb.EarlyConfig.load(EarlyConfig.java:100)
        at System//me.eigenraven.lwjgl3ify.rfb.Lwjgl3ifyRfbPlugin.onConstruction(Lwjgl3ifyRfbPlugin.java:37)
        at com.gtnewhorizons.retrofuturabootstrap.plugin.PluginLoader.initializePlugins(PluginLoader.java:112)
        at System//net.minecraft.launchwrapper.Launch.rfb$realLaunch(Launch.java:197)
        at System//net.minecraft.launchwrapper.Launch.launch(Launch.java:35)
        at System//net.minecraft.launchwrapper.Launch.main(Launch.java:60)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:568)
        at com.gtnewhorizons.retrofuturabootstrap.Main.main(Main.java:207)
        ... 6 more

By the way, is writing this file at startup rather than distributing a config file for it actually desirable?

@YannickMG YannickMG requested a review from eigenraven February 12, 2025 22:42
@YannickMG YannickMG force-pushed the fix-loading-lwjgl3ify-early-json branch from 30fde26 to f86f9f4 Compare February 12, 2025 22:43
@Dream-Master Dream-Master requested a review from a team February 13, 2025 10:57
@eigenraven eigenraven merged commit 449cf73 into master Feb 13, 2025
1 check passed
@eigenraven eigenraven deleted the fix-loading-lwjgl3ify-early-json branch February 13, 2025 20:07
@eigenraven
Copy link
Member

Generating this file on startup is desired, because it contains OS-specific information like the cached list of java installations on the computer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants