Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduction of ATOL in finite vectorisation method #348
Introduction of ATOL in finite vectorisation method #348
Changes from 8 commits
9c45abc
9b4de0e
285919a
5d5a2b1
588e712
7eed21c
a22b48e
3d12635
cdba604
bef50e1
b7a3e9e
76529ca
a90843c
ec1c3ad
1abc47f
4a558f9
b1f656f
af49fdd
b7d9cc2
96eb09e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this isn't meant to be used with a single center.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually there is no reason why it should not, and it is interesting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something that we can consider parallelizing in the future (not in the initial PR), or is it expected that the costly part is
fit
and it would be useless to try and speed uptransform
, which is already very fast (much faster than whatever produced the diagrams in the first place)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ATOL does not necessarily apply to diagrams, it could be simpler objects that have near zero production cost.
You're right about parallelizing the
transform
: our research shows ATOL can be very useful even after a rough calibration, so it's very likely that there are situations wherefit
will necessarily be quick and dirty, but then there is a lot oftransform
ing to be done.