Merge pull request #105 from Gachon-Table/GTB-85

GTB-85 [fix] 주점 관리 기능 수정

src/main/java/site/gachontable/gachontablebe/domain/admin/usecase/ManagePubImpl.java

@@ -17,7 +17,6 @@
 import java.util.List;
 import java.util.Map;
 import java.util.stream.Collectors;
-import java.util.stream.IntStream;
 
 @Service
 @RequiredArgsConstructor
@@ -34,35 +33,27 @@ public String execute(AuthDetails authDetails, PubManageRequest request) {
                 .orElseThrow(AdminNotFoundException::new)
                 .getPub();
 
-        manageThumbnails(request.thumbnails(), pub);
-        manageMenus(request, pub);
+        replaceThumbnails(request.thumbnails(), pub);
+        replaceMenus(request.menuRequests(), pub);
 
         return SuccessCode.MANAGE_PUB_SUCCESS.getMessage();
     }
 
-    private void manageThumbnails(List<String> thumbnails, Pub pub) {
-        List<Thumbnail> existingThumbnails = thumbnailRepository.findAllByPub(pub);
+    private void replaceThumbnails(List<String> thumbnails, Pub pub) {
+        thumbnailRepository.deleteAllByPub(pub);
 
-        IntStream.range(0, thumbnails.size()).forEach(i -> {
-            String url = thumbnails.get(i);
+        List<Thumbnail> newThumbnails = thumbnails.stream()
+                .map(url -> Thumbnail.create(url, pub))
+                .toList();
 
-            if (i < existingThumbnails.size()) {
-                Thumbnail existingThumbnail = existingThumbnails.get(i);
-                if (!existingThumbnail.getUrl().equals(url)) {
-                    existingThumbnail.update(url);
-                }
-
-                return;
-            }
-            thumbnailRepository.save(Thumbnail.create(url, pub));
-        });
+        thumbnailRepository.saveAll(newThumbnails);
     }
 
-    private void manageMenus(PubManageRequest request, Pub pub) {
+    private void replaceMenus(List<PubManageRequest.MenuRequest> request, Pub pub) {
         Map<Integer, Menu> existingMenus = menuRepository.findAllByPub(pub).stream()
                 .collect(Collectors.toMap(Menu::getMenuId, menu -> menu));
 
-        List<Menu> updatedMenus = request.menuRequests().stream()
+        List<Menu> updatedMenus = request.stream()
                 .map(menuRequest -> {
                     Menu menu = existingMenus.get(menuRequest.menuId());
                     if (menu != null) {
@@ -71,6 +62,7 @@ private void manageMenus(PubManageRequest request, Pub pub) {
                                 menuRequest.price(),
                                 menuRequest.oneLiner(),
                                 menuRequest.thumbnail());
+                        existingMenus.remove(menuRequest.menuId());
                         return menu;
                     }
                     return Menu.create(
@@ -82,5 +74,6 @@ private void manageMenus(PubManageRequest request, Pub pub) {
                 }).toList();
 
         menuRepository.saveAll(updatedMenus);
+        menuRepository.deleteAll(existingMenus.values());
     }
 }

src/main/java/site/gachontable/gachontablebe/domain/pub/domain/repository/ThumbnailRepository.java

@@ -12,5 +12,5 @@ public interface ThumbnailRepository extends JpaRepository<Thumbnail, Long> {
     @Query("SELECT t.url FROM thumbnail t WHERE t.pub = :pub")
     List<String> findUrlsByPub(Pub pub);
 
-    List<Thumbnail> findAllByPub(Pub pub);
+    void deleteAllByPub(Pub pub);
 }

src/main/java/site/gachontable/gachontablebe/domain/waiting/usecase/GetStatusByBiztalkImpl.java

@@ -2,6 +2,7 @@
 
 import lombok.RequiredArgsConstructor;
 import org.springframework.stereotype.Service;
+import org.springframework.transaction.annotation.Transactional;
 import site.gachontable.gachontablebe.domain.pub.domain.Pub;
 import site.gachontable.gachontablebe.domain.waiting.domain.Waiting;
 import site.gachontable.gachontablebe.domain.waiting.domain.repository.WaitingRepository;
@@ -18,6 +19,7 @@ public class GetStatusByBiztalkImpl implements GetStatusByBiztalk {
 
     private final WaitingRepository waitingRepository;
 
+    @Transactional(readOnly = true)
     @Override
     public StatusResponse execute(UUID waitingId) {
         Waiting waiting = waitingRepository.findById(waitingId)

src/main/resources/application-dev.yaml

@@ -7,7 +7,7 @@ spring:
   jpa:
     show-sql: false
     hibernate:
-      ddl-auto: update
+      ddl-auto: validate
     database: mysql
     database-platform: org.hibernate.dialect.MySQLDialect
     properties: