GTB-33 [feat] 주점 상세정보 API 구현 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
고생하셨습니다! 레코드 안에 레코드를 넣은 구조는 처음보는데 읽어보니 좋은 구조인것 같네요! |
jwnnoh
reviewed
Jun 2, 2024
src/main/java/site/gachontable/gachontablebe/domain/pub/presentation/PubController.java
Show resolved
Hide resolved
jwnnoh
requested changes
Jun 2, 2024
There was a problem hiding this comment.
고생하셨습니다! 몇 가지 수정 사항을 작성하였는데, 확인 부탁 드립니다.
추가적으로, 작성하신 코드와 PR의 제목 및 내용이 일치하지 않는 것 같습니다.
제목은 수정하였으니, 내용은 @rootTiket 님께서 마저 수정해주시면 감사하겠습니다!
...n/java/site/gachontable/gachontablebe/domain/pub/presentation/dto/GetPubDetailsResponse.java
Outdated
Show resolved
Hide resolved
...n/java/site/gachontable/gachontablebe/domain/pub/presentation/dto/GetPubDetailsResponse.java
Outdated
Show resolved
Hide resolved
...n/java/site/gachontable/gachontablebe/domain/pub/presentation/dto/GetPubDetailsResponse.java
Outdated
Show resolved
Hide resolved
...n/java/site/gachontable/gachontablebe/domain/pub/presentation/dto/GetPubDetailsResponse.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 무슨 이유로 코드를 변경했나요?
주점 상세정보 API를 구현했습니다
2. 어떤 위험이나 장애를 발견했나요?
액세스 토큰이 유효하지 않을 경우 리프레시 토큰을 확인하여 토큰 재 발급하는 로직이 보이지 않아 우선 비 로그인 상태로 사용할 수 있게 구현하였습니다.
3. 관련 스크린샷을 첨부해주세요.
4. 완료 사항
5. 추가 사항
close #26