-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GTB-41 [feat] 관리자 페이지 주점 웨이팅 현황 API 구현 #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다! 몇 가지 의견을 남겨두었으니, 확인해주시면 감사하겠습니다
src/main/java/site/gachontable/gachontablebe/domain/admin/presentation/AdminController.java
Outdated
Show resolved
Hide resolved
src/main/java/site/gachontable/gachontablebe/domain/admin/presentation/AdminController.java
Outdated
Show resolved
Hide resolved
src/main/java/site/gachontable/gachontablebe/domain/admin/presentation/AdminController.java
Outdated
Show resolved
Hide resolved
src/main/java/site/gachontable/gachontablebe/domain/waiting/usecase/GetWaitingList.java
Outdated
Show resolved
Hide resolved
src/main/java/site/gachontable/gachontablebe/domain/waiting/usecase/GetWaitingList.java
Outdated
Show resolved
Hide resolved
고생하셨습니다! |
src/main/java/site/gachontable/gachontablebe/domain/admin/presentation/AdminController.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다! 피드백 확인 부탁드립니다!
src/main/java/site/gachontable/gachontablebe/domain/admin/presentation/AdminController.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
1. 무슨 이유로 코드를 변경했나요?
관리자 페이지에서 유저의 웨이팅 현황을 확인하는 API를 구현하였습니다.
2. 어떤 위험이나 장애를 발견했나요?
사용자가 현장웨이팅인 경우 유저 객체로 식별 할 수 없어 오류가 있었습니다. 현재는 수정했습니다.
3. 관련 스크린샷을 첨부해주세요.
4. 완료 사항
5. 추가 사항
close #36