-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GTB-74 [refactor] 주점 관리 API 변경 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`menuId`를 통한 기존 메뉴 여부 판단 로직 수정
rootTiket
reviewed
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
정책 변경에 맞게 잘 변경된 것 같습니다 !! 고생하셨어요 :)
yechan-kim
reviewed
Sep 11, 2024
Comment on lines
+49
to
+62
if (menu != null) { | ||
menu.update( | ||
menuRequest.menuName(), | ||
menuRequest.price(), | ||
menuRequest.oneLiner(), | ||
menuRequest.thumbnail()); | ||
return menu; | ||
} | ||
return Menu.create( | ||
pub, | ||
menuRequest.menuName(), | ||
menuRequest.price(), | ||
menuRequest.oneLiner(), | ||
menuRequest.thumbnail()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
말씀하신 로직이 해당 로직 같은데, 매우 흥미롭게 봤습니다! 고생하셨습니다!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 무슨 이유로 코드를 변경했나요?
메뉴 등록 및 관리
🤔 기존에 존재하는 메뉴는 어떻게 판단하나요?
menuId
가 포함되어 있는 메뉴는update
,create
메서드로 진행하도록 분기하였습니다.2. 어떤 위험이나 장애를 발견했나요?
3. 관련 스크린샷을 첨부해주세요.
4. 완료 사항
이슈 번호
close #84
5. 추가 사항
StudentCard
->Nullable
allocated
필드 삭제