Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky update tests #756

Closed
TethysSvensson opened this issue Oct 2, 2016 · 1 comment
Closed

Flaky update tests #756

TethysSvensson opened this issue Oct 2, 2016 · 1 comment
Labels
bug testing
Milestone
3.2.0

Comments

@TethysSvensson
Copy link
Contributor

Our doctests for checking if update.py works correctly is very flaky. I assume it is caused by github limiting our requests.
@TethysSvensson TethysSvensson changed the title Flake update tests Flaky update tests Oct 2, 2016
@TethysSvensson TethysSvensson added this to the 3.2.0 milestone Oct 2, 2016
@zachriggle
Copy link
Member

I have no ideas for this. If we use an API key, instead of us being grouped with Travis CI's users, all of the Pwntools users will be grouped together -- potentially causing update failures.

We could just remove the Github check altogether?

zachriggle added a commit to zachriggle/pwntools that referenced this issue Oct 7, 2016
@zachriggle
Remove all Github update checks
643cdc7 
These were nice-to-have, but as long as PyPi is updated and functioning
properly, we don't need to check Github.

Fixes Gallopsled#756
@zachriggle zachriggle mentioned this issue Oct 7, 2016
Merged
zachriggle added a commit that referenced this issue Oct 7, 2016
@zachriggle
Remove all Github update checks (#761)
aec3fa6 
These were nice-to-have, but as long as PyPi is updated and functioning
properly, we don't need to check Github.

Fixes #756
TethysSvensson pushed a commit that referenced this issue Oct 18, 2016
@zachriggle
Remove all Github update checks (#761)
3f48a0b 
These were nice-to-have, but as long as PyPi is updated and functioning
properly, we don't need to check Github.

Fixes #756
Kyle-Kyle pushed a commit to Kyle-Kyle/pwntools that referenced this issue Apr 25, 2021
@layderv
Gallopsled#664 mark changed registers (Gallopsled#756)
b361bda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug testing
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
2 participants
@zachriggle @TethysSvensson